Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2667)

Unified Diff: android_webview/apk/system_webview_apk_common.gypi

Issue 903793002: Name V8 snapshot according to target architecture (32/64 bit). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/android_webview_tests.gypi ('k') | android_webview/lib/main/aw_main_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/apk/system_webview_apk_common.gypi
diff --git a/android_webview/apk/system_webview_apk_common.gypi b/android_webview/apk/system_webview_apk_common.gypi
index dae95acb1549adf5184830d303fd6f277f2d44a5..547f0ae72ff7f9efcf4ee0ca3856cdcfc506a380 100644
--- a/android_webview/apk/system_webview_apk_common.gypi
+++ b/android_webview/apk/system_webview_apk_common.gypi
@@ -33,11 +33,17 @@
'<(asset_location)/icudtl.dat',
],
}],
- ['v8_use_external_startup_data==1', {
+ ['v8_use_external_startup_data==1 and (target_arch=="arm" or target_arch=="x86" or target_arch=="mips")', {
Torne 2015/02/06 12:17:24 We should probably put this section in a .gypi fil
'additional_input_paths': [
- '<(asset_location)/natives_blob.bin',
- '<(asset_location)/snapshot_blob.bin',
- ],
+ '<(asset_location)/natives_blob_32.bin',
+ '<(asset_location)/snapshot_blob_32.bin',
+ ],
+ }],
+ ['v8_use_external_startup_data==1 and (target_arch=="arm64" or target_arch=="x86_64" or target_arch=="mips64")', {
+ 'additional_input_paths': [
+ '<(asset_location)/natives_blob_64.bin',
+ '<(asset_location)/snapshot_blob_64.bin',
+ ],
}],
],
},
@@ -54,10 +60,16 @@
'<(PRODUCT_DIR)/icudtl.dat',
],
}],
- ['v8_use_external_startup_data==1', {
+ ['v8_use_external_startup_data==1 and (target_arch=="arm" or target_arch=="x86" or target_arch=="mips")', {
+ 'files': [
+ '<(PRODUCT_DIR)/natives_blob_32.bin',
+ '<(PRODUCT_DIR)/snapshot_blob_32.bin',
+ ],
+ }],
+ ['v8_use_external_startup_data==1 and (target_arch=="arm64" or target_arch=="x86_64" or target_arch=="mips64")', {
'files': [
- '<(PRODUCT_DIR)/natives_blob.bin',
- '<(PRODUCT_DIR)/snapshot_blob.bin',
+ '<(PRODUCT_DIR)/natives_blob_64.bin',
+ '<(PRODUCT_DIR)/snapshot_blob_64.bin',
],
}],
],
« no previous file with comments | « android_webview/android_webview_tests.gypi ('k') | android_webview/lib/main/aw_main_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698