components/test/data/password_manager/automated_tests/environment.py - Issue 903763003: Refactoring and paralelizing Python password manager tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test/data/password_manager/automated_tests/environment.py

Issue 903763003: Refactoring and paralelizing Python password manager tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Small fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/test/data/password_manager/automated_tests/run_tests.py » ('j') | components/test/data/password_manager/automated_tests/run_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test/data/password_manager/automated_tests/environment.py

diff --git a/components/test/data/password_manager/automated_tests/environment.py b/components/test/data/password_manager/automated_tests/environment.py

index 86685b30057499ffd314ea4d28b654d27cb0a4fa..71eca92129228c40e6d6ed4f27d6e4a65addaa0a 100644

--- a/components/test/data/password_manager/automated_tests/environment.py

+++ b/components/test/data/password_manager/automated_tests/environment.py

@@ -87,10 +87,7 @@ class Environment:

try:

shutil.rmtree(profile_path)

except Exception, e:

- # The tests execution can continue, but this make them less stable.

- logging.error("Error: Could not wipe the chrome profile directory (%s). \

- This affects the stability of the tests. Continuing to run tests."

- % e)

+ pass

# If |chrome_path| is not defined, this means that we are in the dashboard

# website, and we just need to get the list of all websites. In this case,

# we don't need to initilize the webdriver.