Revert of Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Revert of Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #2 id:270001 of https://codereview.chromium.org/899983002/)

Reason for revert:
It turns out that the crash wasn't caused by this CL.

Original issue's description:
> Revert of Introduce HostID and de-couple Extensions from "script injection System" [browser side] (patchset #20 id:760001 of https://codereview.chromium.org/822453002/)
>
> Reason for revert:
> It might cause the crash https://code.google.com/p/chromium/issues/detail?id=454917.
>
> Original issue's description:
> > Introduce HostID and de-couple Extensions from "script injection System" [browser side]
> >
> > The major refactor includes:
> > - Introduce HostID (a pair of |id, type|) to replace extension_id in browser
> >   side.
> > - Abstract UserScriptLoader to be a base class, and introduces
> >   a derived class ExtensionUserScriptLoader which is
> >   responsible for loading user scripts for extensions.
> > - In DeclarativeUserScriptManager, a master is created per
> >   extension/webUI.
> > - DeclarativeUserScriptManager becomes an
> >   ExtensionRegistryObserver and is responsible for clearing scripts
> >   for master objects when receive OnExensionUnloaded event.
> >
> > BUG=437566
> >
> > Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
> > Cr-Commit-Position: refs/heads/master@{#313402}
>
> TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=437566
>
> Committed: https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575
> Cr-Commit-Position: refs/heads/master@{#314631}

TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=437566
Committed: https://crrev.com/c0503d76ca4216349132b8a2ca1db5a15a11292a
Cr-Commit-Position: refs/heads/master@{#314807}

[Xi Han, 2015-02-05 14:22:04]

Created Revert of Revert of Introduce HostID and de-couple Extensions from
"script injection System" [browser side]

[Xi Han, 2015-02-05 14:22:46]

The CQ bit was unchecked by hanxi@chromium.org

[Xi Han, 2015-02-05 14:25:53]

The CQ bit was checked by hanxi@chromium.org

[Devlin, 2015-02-05 16:38:58]

FYI, the "Revert Patchset" button is really there for quick,
need-to-revert-now-to-keep-the-tree-green type of things.  For this reason,
it applies things like a NOTRY=true, which can be very dangerous.  When
reverting (or resubmitting) a patchset from more than a few hours ago, it's
really best to not use these labels, and the let the patchset land with the
CQ.

(Coincidentally, there's a whole discussion thread on restricting the use
of NOTRY on chromium-dev at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/RPY9zVuyplw
).

Before resubmitting, please take off the NOTRY, NOPRESUBMIT, and
NOTREECHECKS.

On Thu, Feb 5, 2015 at 6:22 AM, <hanxi@chromium.org> wrote:

> Reviewers: Fady Samuel, Devlin,
>
> Message:
> Created Revert of Revert of Introduce HostID and de-couple Extensions from
> "script injection System" [browser side]
>
> Description:
> Revert of Revert of Introduce HostID and de-couple Extensions from "script
> injection System" [browser side] (patchset #2 id:270001 of
> https://codereview.chromium.org/899983002/)
>
> Reason for revert:
> It turns out that the crash wasn't caused by this CL.
>
> Original issue's description:
>
>> Revert of Introduce HostID and de-couple Extensions from "script injection
>>
> System" [browser side] (patchset #20 id:760001 of
> https://codereview.chromium.org/822453002/)
>
>  Reason for revert:
>> It might cause the crash
>>
> https://code.google.com/p/chromium/issues/detail?id=454917.
>
>  Original issue's description:
>> > Introduce HostID and de-couple Extensions from "script injection System"
>>
> [browser side]
>
>> >
>> > The major refactor includes:
>> > - Introduce HostID (a pair of |id, type|) to replace extension_id in
>> browser
>> >   side.
>> > - Abstract UserScriptLoader to be a base class, and introduces
>> >   a derived class ExtensionUserScriptLoader which is
>> >   responsible for loading user scripts for extensions.
>> > - In DeclarativeUserScriptManager, a master is created per
>> >   extension/webUI.
>> > - DeclarativeUserScriptManager becomes an
>> >   ExtensionRegistryObserver and is responsible for clearing scripts
>> >   for master objects when receive OnExensionUnloaded event.
>> >
>> > BUG=437566
>> >
>> > Committed: https://crrev.com/b88fe3dc1072501bdd105fd95a8b3bc453fd2aa7
>> > Cr-Commit-Position: refs/heads/master@{#313402}
>>
>
>  TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
>> NOPRESUBMIT=true
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=437566
>>
>
>  Committed: https://crrev.com/5eb894ea21637241e9a78fb9c2737d40d6dbf575
>> Cr-Commit-Position: refs/heads/master@{#314631}
>>
>
> TBR=fsamuel@chromium.org,rdevlin.cronin@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=437566
>
> Please review this at https://codereview.chromium.org/903743002/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+898, -621 lines):
>   M chrome/browser/extensions/api/declarative_content/chrome_
> content_rules_registry.cc
>   M chrome/browser/extensions/api/declarative_content/content_action.h
>   M chrome/browser/extensions/api/declarative_content/content_action.cc
>   M chrome/browser/extensions/api/declarative_content/content_
> action_unittest.cc
>   M chrome/browser/extensions/api/declarative_webrequest/
> webrequest_action_unittest.cc
>   M chrome/browser/extensions/api/declarative_webrequest/
> webrequest_rules_registry_unittest.cc
>   M chrome/browser/extensions/convert_user_script.cc
>   M chrome/browser/extensions/declarative_user_script_manager.h
>   M chrome/browser/extensions/declarative_user_script_manager.cc
>   M chrome/browser/extensions/declarative_user_script_master.h
>   M chrome/browser/extensions/declarative_user_script_master.cc
>   A chrome/browser/extensions/extension_user_script_loader.h
>   A chrome/browser/extensions/extension_user_script_loader.cc
>   A chrome/browser/extensions/extension_user_script_loader_unittest.cc
>   M chrome/browser/extensions/shared_user_script_master.h
>   M chrome/browser/extensions/shared_user_script_master.cc
>   M chrome/browser/extensions/user_script_loader.h
>   M chrome/browser/extensions/user_script_loader.cc
>   D chrome/browser/extensions/user_script_loader_unittest.cc
>   M chrome/chrome_browser_extensions.gypi
>   M chrome/chrome_tests_unit.gypi
>   M chrome/common/extensions/manifest_handlers/content_scripts_handler.cc
>   M extensions/browser/api/declarative/declarative_rule.h
>   M extensions/browser/api/declarative/declarative_rule_unittest.cc
>   M extensions/browser/api/declarative_webrequest/webrequest_action.h
>   M extensions/browser/api/declarative_webrequest/webrequest_action.cc
>   M extensions/browser/api/declarative_webrequest/
> webrequest_rules_registry.cc
>   M extensions/common/BUILD.gn
>   A extensions/common/host_id.h
>   M extensions/common/user_script.h
>   M extensions/common/user_script.cc
>   M extensions/common/user_script_unittest.cc
>   M extensions/extensions.gyp
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.