Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 903703002: Split --harmony-unicode and --harmony-unicode-regexps. (Closed)

Created:
5 years, 10 months ago by marja
Modified:
5 years, 10 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Split --harmony-unicode and --harmony-unicode-regexps. This way we can ship \u{..} escapes in strings / identifiers before shipping /u regexps. BUG= Committed: https://crrev.com/299b369cc950e221389eb4c585128c55155f9bc1 Cr-Commit-Position: refs/heads/master@{#26461}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -108 lines) Patch
M src/bootstrapper.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M src/flag-definitions.h View 1 2 chunks +11 lines, -9 lines 0 comments Download
M src/heap/heap.h View 1 chunk +79 lines, -79 lines 0 comments Download
M src/parser.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M src/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/regexp-flags.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/mirror-regexp.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
marja
rossberg, ptal
5 years, 10 months ago (2015-02-05 13:29:02 UTC) #2
rossberg
lgtm
5 years, 10 months ago (2015-02-05 14:13:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903703002/20001
5 years, 10 months ago (2015-02-05 14:14:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-05 14:17:02 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 14:17:22 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/299b369cc950e221389eb4c585128c55155f9bc1
Cr-Commit-Position: refs/heads/master@{#26461}

Powered by Google App Engine
This is Rietveld 408576698