Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5983)

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc

Issue 903683005: Always prompt for permission on fullscreen and mouse lock on file:// URLs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated Mac UI for fullscreen on file:// URLs Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
diff --git a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
index 8b6dfa07803cf22a12a47ba5c3c42cbd8057094c..e161e1f6f0daeab330d691121d6f5850442c5bed 100644
--- a/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
+++ b/chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
@@ -55,3 +55,19 @@ TEST(PermissionMenuModelTest, TestAllowBlock) {
callback.callback());
EXPECT_EQ(2, model.GetItemCount());
}
+
+TEST(PermissionMenuModelTest, TestFullscreenMouseLockFileUrl) {
+ TestCallback callback;
+ WebsiteSettingsUI::PermissionInfo permission;
+ permission.type = CONTENT_SETTINGS_TYPE_FULLSCREEN;
+ permission.setting = CONTENT_SETTING_ASK;
+ permission.default_setting = CONTENT_SETTING_ASK;
+ PermissionMenuModel fullscreen_model(GURL("file:///test.html"), permission,
+ callback.callback());
+ EXPECT_EQ(1, fullscreen_model.GetItemCount());
msw 2015/02/12 00:07:59 nit: Maybe check GetCommandIdAt(0) or GetLabelAt(0
estark 2015/02/12 02:33:10 Done.
+
+ permission.type = CONTENT_SETTINGS_TYPE_MOUSELOCK;
+ PermissionMenuModel mouselock_model(GURL("file:///test.html"), permission,
+ callback.callback());
+ EXPECT_EQ(1, mouselock_model.GetItemCount());
+}

Powered by Google App Engine
This is Rietveld 408576698