Always prompt for permission on fullscreen and mouse lock on file:// URLs

chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc

Index: chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
diff --git a/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc b/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
index c403bb527f55d8e98f61304a5ec2b253f6261525..184d75f3d2f432c14afbe59e1f83a9a41d113122 100644
--- a/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
+++ b/chrome/browser/ui/exclusive_access/fullscreen_controller_browsertest.cc
@@ -11,6 +11,7 @@
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/render_view_host.h"

[msw, 2015/02/12 00:07:59]

nit: this and some other headers may not be used anymore, I thought we had an
iwyu script, but I can't find it, maybe take a quick manual look through these?

[estark, 2015/02/12 02:33:10]

Done.

 #include "content/public/browser/web_contents.h"
 #include "content/public/common/url_constants.h"
@@ -74,3 +75,27 @@ IN_PROC_BROWSER_TEST_F(FullscreenControllerTest,
   }
   ASSERT_FALSE(IsFullscreenBubbleDisplayed());
 }
+
+IN_PROC_BROWSER_TEST_F(FullscreenControllerTest, MouseLockOnFileURL) {

[msw, 2015/02/12 00:07:59]

You may want to add a file URL test case to
fullscreen_controller_interactive_browsertest.cc, but so many of those tests are
DISABLED_ or MAYBE_ for flakiness that maybe that isn't terribly worthwhile...

+  static const base::FilePath::CharType* kEmptyFile =
+      FILE_PATH_LITERAL("empty.html");
+  GURL file_url(ui_test_utils::GetTestUrl(
+      base::FilePath(base::FilePath::kCurrentDirectory),
+      base::FilePath(kEmptyFile)));
+  AddTabAtIndex(0, file_url, PAGE_TRANSITION_TYPED);
+  RequestToLockMouse(true, false);
+  ASSERT_TRUE(IsFullscreenBubbleDisplayed());
+  ASSERT_TRUE(IsFullscreenBubbleDisplayingButtons());
+}
+
+IN_PROC_BROWSER_TEST_F(FullscreenControllerTest, FullscreenOnFileURL) {
+  static const base::FilePath::CharType* kEmptyFile =
+      FILE_PATH_LITERAL("empty.html");
+  GURL file_url(ui_test_utils::GetTestUrl(
+      base::FilePath(base::FilePath::kCurrentDirectory),
+      base::FilePath(kEmptyFile)));
+  AddTabAtIndex(0, file_url, PAGE_TRANSITION_TYPED);
+  RequestToLockMouse(true, false);
+  ASSERT_TRUE(IsFullscreenBubbleDisplayed());
+  ASSERT_TRUE(IsFullscreenBubbleDisplayingButtons());
+}