Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/css/SelectorCheckerFastPath.cpp

Issue 90363003: Get rid of useless calls to AtomicString::impl() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/css/RuleFeature.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 element = topChildOrSubselectorMatchElement->parentElement(); 68 element = topChildOrSubselectorMatchElement->parentElement();
69 topChildOrSubselector = 0; 69 topChildOrSubselector = 0;
70 return true; 70 return true;
71 } 71 }
72 } 72 }
73 return false; 73 return false;
74 } 74 }
75 75
76 inline bool checkClassValue(const Element& element, const CSSSelector* selector) 76 inline bool checkClassValue(const Element& element, const CSSSelector* selector)
77 { 77 {
78 return element.hasClass() && element.classNames().contains(selector->value() .impl()); 78 return element.hasClass() && element.classNames().contains(selector->value() );
79 } 79 }
80 80
81 inline bool checkIDValue(const Element& element, const CSSSelector* selector) 81 inline bool checkIDValue(const Element& element, const CSSSelector* selector)
82 { 82 {
83 return element.hasID() && element.idForStyleResolution().impl() == selector- >value().impl(); 83 return element.hasID() && element.idForStyleResolution() == selector->value( );
84 } 84 }
85 85
86 inline bool checkExactAttributeValue(const Element& element, const CSSSelector* selector) 86 inline bool checkExactAttributeValue(const Element& element, const CSSSelector* selector)
87 { 87 {
88 return SelectorChecker::checkExactAttribute(element, selector->attribute(), selector->value().impl()); 88 return SelectorChecker::checkExactAttribute(element, selector->attribute(), selector->value().impl());
89 } 89 }
90 90
91 inline bool checkTagValue(const Element& element, const CSSSelector* selector) 91 inline bool checkTagValue(const Element& element, const CSSSelector* selector)
92 { 92 {
93 return SelectorChecker::tagMatches(element, selector->tagQName()); 93 return SelectorChecker::tagMatches(element, selector->tagQName());
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 case CSSSelector::PseudoFocus: 215 case CSSSelector::PseudoFocus:
216 return SelectorChecker::matchesFocusPseudoClass(m_element); 216 return SelectorChecker::matchesFocusPseudoClass(m_element);
217 default: 217 default:
218 ASSERT_NOT_REACHED(); 218 ASSERT_NOT_REACHED();
219 } 219 }
220 return true; 220 return true;
221 } 221 }
222 222
223 223
224 } 224 }
OLDNEW
« no previous file with comments | « Source/core/css/RuleFeature.cpp ('k') | Source/core/css/resolver/StyleBuilderCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698