win: warning fixes in minidump_thread_writer_test.cc

win: warning fixes in minidump_thread_writer_test.cc

- unaligned due to heap allocation
- potentially uninitialized local
- truncation of uint64_t -> DWORD

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b7d214e741acf7e133ea13af41dfc92800c53aaa

[Mark Mentovai, 2015-02-05 14:27:41]

LGTM

https://codereview.chromium.org/903603002/diff/1/minidump/minidump_thread_wri...
File minidump/minidump_thread_writer_test.cc (right):

https://codereview.chromium.org/903603002/diff/1/minidump/minidump_thread_wri...
minidump/minidump_thread_writer_test.cc:224: #pragma warning(disable: 4316)  //
Object allocated on heap may not be aligned.
And if this one shows up frequently, maybe we should consolidate it into static
MinidumpContextAMD64Writer* MinidumpContextAMD64Writer::New().

[scottmg, 2015-02-05 17:48:34]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-05 17:50:42]

https://codereview.chromium.org/903603002/diff/1/minidump/minidump_thread_wri...
File minidump/minidump_thread_writer_test.cc (right):

https://codereview.chromium.org/903603002/diff/1/minidump/minidump_thread_wri...
minidump/minidump_thread_writer_test.cc:224: #pragma warning(disable: 4316)  //
Object allocated on heap may not be aligned.
On 2015/02/05 14:27:41, Mark Mentovai wrote:
> And if this one shows up frequently, maybe we should consolidate it into
static
> MinidumpContextAMD64Writer* MinidumpContextAMD64Writer::New().

Switched to shorter MSVC_SUPPRESS_WARNING. Hiding it in a function might be
sensible, but potentially a little surprising if alignment is expected for the
member?

[scottmg, 2015-02-05 17:52:28]

Committed patchset #2 (id:20001) manually as
b7d214e741acf7e133ea13af41dfc92800c53aaa (presubmit successful).

[Mark Mentovai, 2015-02-05 18:21:31]

https://codereview.chromium.org/903603002/diff/20001/minidump/minidump_thread...
File minidump/minidump_thread_writer_test.cc (right):

https://codereview.chromium.org/903603002/diff/20001/minidump/minidump_thread...
minidump/minidump_thread_writer_test.cc:222: MSVC_SUPPRESS_WARNING(4316)  //
Object allocated on heap may not be aligned.
A semicolon will make this look a little more code-y and will be more easily
dealt with by fake parsers.

[scottmg, 2015-02-05 18:38:30]

On 2015/02/05 18:21:31, Mark Mentovai wrote:
>
https://codereview.chromium.org/903603002/diff/20001/minidump/minidump_thread...
> File minidump/minidump_thread_writer_test.cc (right):
> 
>
https://codereview.chromium.org/903603002/diff/20001/minidump/minidump_thread...
> minidump/minidump_thread_writer_test.cc:222: MSVC_SUPPRESS_WARNING(4316)  //
> Object allocated on heap may not be aligned.
> A semicolon will make this look a little more code-y and will be more easily
> dealt with by fake parsers.

I'll roll that into https://codereview.chromium.org/898133002/.