Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 903583002: Fix GetFontData calling itself repeatedly until the process crashes. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GetFontData calling itself repeatedly until the process crashes. It looks like the GetFontData patch for PDFium is only used on XP/Vista now. Previously PDFium was in a separate binary so we were just calling the real GetFontData from chrome_child.dll. That doesn't work anymore, so use the original function pointer. BUG=455399 Committed: https://crrev.com/97823ee2d8054183f2b011313a06c28f1945ca23 Cr-Commit-Position: refs/heads/master@{#314706}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/child/pdf_child_init.cc View 3 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jam
5 years, 10 months ago (2015-02-05 00:44:50 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-05 00:46:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903583002/1
5 years, 10 months ago (2015-02-05 00:50:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 01:30:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 01:31:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97823ee2d8054183f2b011313a06c28f1945ca23
Cr-Commit-Position: refs/heads/master@{#314706}

Powered by Google App Engine
This is Rietveld 408576698