Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 903543002: Temporary workaround for flashing buts on Mac (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
Reviewers:
weiliangc
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporary workaround for flashing buts on Mac Do not re-set the root layer for the ui::Compositor when suspending the browser compositor view. Prior to moving the ui::Compositor to use the scheduler, this would prevent frames from appearing. Now it causes blank flashes. There are still blue (debug) flashes when returning from fullscreen and when the GPU process is killed. These still need to be fixed. BUG=454682 Committed: https://crrev.com/afebf76e26c5cecb3fa043c410f64ed96243a09e Cr-Commit-Position: refs/heads/master@{#314632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M content/browser/renderer_host/render_widget_host_view_mac.mm View 4 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
This will ensure that Mac Canary/Dev isn't in too-terrible shape while I sort out a ...
5 years, 10 months ago (2015-02-04 20:05:23 UTC) #2
weiliangc
On 2015/02/04 at 20:05:23, ccameron wrote: > This will ensure that Mac Canary/Dev isn't in ...
5 years, 10 months ago (2015-02-04 20:14:33 UTC) #3
ccameron
Thanks for the quick review!
5 years, 10 months ago (2015-02-04 20:21:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903543002/1
5 years, 10 months ago (2015-02-04 20:22:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 21:09:25 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:10:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afebf76e26c5cecb3fa043c410f64ed96243a09e
Cr-Commit-Position: refs/heads/master@{#314632}

Powered by Google App Engine
This is Rietveld 408576698