Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 903523002: Revert of Remove usages of Timeline commands in telemetry (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove usages of Timeline commands in telemetry (patchset #4 id:60001 of https://codereview.chromium.org/895043002/) Reason for revert: Windows telemetry unit tests are failing intermittently after this patch. Sample failing build: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/53177 Output: [1/1] telemetry.core.backends.chrome_inspector.inspector_network_unittest.InspectorNetworkTabTest.testHTTPResponseTimelineRecorder failed unexpectedly: Could not find Flash at E:\b\build\slave\Vista_Tests__1_\build\src\third_party\adobe\flash\binaries\ppapi\win\pepflashplayer.dll. Continuing without Flash. To run with Flash, check it out via http://go/read-src-internal Traceback (most recent call last): File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\decorators.py", line 55, in wrapper func(*args, **kwargs) File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\core\backends\chrome_inspector\inspector_network_unittest.py", line 40, in testHTTPResponseTimelineRecorder self.assertEqual(test.responses_count, len(events)) AssertionError: 1 != 2 Original issue's description: > Remove usages of Timeline commands in telemetry > > We are going to remove Timeline domain from the remote debugging protocol soon. This CL fixes remaining usages of timeline commands. > > BUG=448318 > > Committed: https://crrev.com/9ca9eb0c7668c7a7e1f595ea0c4f3bca221e9350 > Cr-Commit-Position: refs/heads/master@{#314522} TBR=caseq@chromium.org,pfeldman@chromium.org,marja@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=448318 Committed: https://crrev.com/07f4d58b145978364219ec53e2965ed700b2da71 Cr-Commit-Position: refs/heads/master@{#314589}

Patch Set 1 #

Messages

Total messages: 7 (1 generated)
ccameron
Created Revert of Remove usages of Timeline commands in telemetry
5 years, 10 months ago (2015-02-04 18:25:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903523002/1
5 years, 10 months ago (2015-02-04 18:25:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 18:27:30 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/07f4d58b145978364219ec53e2965ed700b2da71 Cr-Commit-Position: refs/heads/master@{#314589}
5 years, 10 months ago (2015-02-04 18:28:38 UTC) #4
yurys
The CL just revealed flakiness that has been observed on other bots as well: crbug.com/449979 ...
5 years, 10 months ago (2015-02-06 10:43:49 UTC) #6
yurys
5 years, 10 months ago (2015-02-06 10:45:54 UTC) #7
Message was sent while issue was closed.
On 2015/02/06 10:43:49, yurys wrote:
> The CL just revealed flakiness that has been observed on other bots as well:
> crbug.com/449979
> crbug.com/452279
> crbug.com/455269
> 
> 
> After my CL the test started doing less work and should be completing sooner
> than before. That might be a reason of the increased flakiness. I'm going to
> reland the patch and mark the test as flaky on Vista (it is already disabled
on
> mac, android and win [1]).
> 
> 
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/te...

Oh, in fact it is already disabled on Win [2].

[2]
https://chromium.googlesource.com/chromium/src/+/3197f15cab79f95db67aad31cf60...

Powered by Google App Engine
This is Rietveld 408576698