DescriptionRevert of Remove usages of Timeline commands in telemetry (patchset #4 id:60001 of https://codereview.chromium.org/895043002/)
Reason for revert:
Windows telemetry unit tests are failing intermittently after this patch.
Sample failing build:
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/53177
Output:
[1/1] telemetry.core.backends.chrome_inspector.inspector_network_unittest.InspectorNetworkTabTest.testHTTPResponseTimelineRecorder failed unexpectedly:
Could not find Flash at E:\b\build\slave\Vista_Tests__1_\build\src\third_party\adobe\flash\binaries\ppapi\win\pepflashplayer.dll. Continuing without Flash.
To run with Flash, check it out via http://go/read-src-internal
Traceback (most recent call last):
File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\decorators.py", line 55, in wrapper
func(*args, **kwargs)
File "E:\b\build\slave\Vista_Tests__1_\build\src\tools\telemetry\telemetry\core\backends\chrome_inspector\inspector_network_unittest.py", line 40, in testHTTPResponseTimelineRecorder
self.assertEqual(test.responses_count, len(events))
AssertionError: 1 != 2
Original issue's description:
> Remove usages of Timeline commands in telemetry
>
> We are going to remove Timeline domain from the remote debugging protocol soon. This CL fixes remaining usages of timeline commands.
>
> BUG=448318
>
> Committed: https://crrev.com/9ca9eb0c7668c7a7e1f595ea0c4f3bca221e9350
> Cr-Commit-Position: refs/heads/master@{#314522}
TBR=caseq@chromium.org,pfeldman@chromium.org,marja@chromium.org,yurys@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448318
Committed: https://crrev.com/07f4d58b145978364219ec53e2965ed700b2da71
Cr-Commit-Position: refs/heads/master@{#314589}
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (1 generated)
|