Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 903513002: Change ipc_perftests large-message test count to 1,000 (Closed)

Created:
5 years, 10 months ago by brucedawson
Modified:
5 years, 10 months ago
Reviewers:
Hajime Morrita, agl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change ipc_perftests large-message test count to 1,000 The ipc_perftests and mojo_message_pipe_perftests results appeared designed to be compared against each other, and the ipc_perftests appear to be designed to take about a second each. Therefore it is presumably a bug that the final ipc_perftests test executes only 100 times (versus 1,000 times for mojo_message_pipe_perftests) and that it executes in ~50 ms. This change increases the iteration count from 100 to 1,000. Committed: https://crrev.com/903fdfd764c0a298862a47630fa5db146bc874cb Cr-Commit-Position: refs/heads/master@{#314698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ipc/ipc_perftest_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Hajime Morrita
LGTM but I'm not an owner. agl: Could you rubberstamp this?
5 years, 10 months ago (2015-02-04 22:54:25 UTC) #2
agl
lgtm
5 years, 10 months ago (2015-02-04 23:08:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903513002/1
5 years, 10 months ago (2015-02-04 23:46:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 00:58:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 00:59:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/903fdfd764c0a298862a47630fa5db146bc874cb
Cr-Commit-Position: refs/heads/master@{#314698}

Powered by Google App Engine
This is Rietveld 408576698