Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1536)

Unified Diff: tests/standalone/src/FileInvalidArgumentsTest.dart

Issue 9034005: Change the behavior of open on files to not truncate by default (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comment.s Created 8 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/main.cc ('k') | tests/standalone/src/FileTest.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/src/FileInvalidArgumentsTest.dart
diff --git a/tests/standalone/src/FileInvalidArgumentsTest.dart b/tests/standalone/src/FileInvalidArgumentsTest.dart
index fc6ffe36963a3fa79cf4fa0ee9c1e549ed71fa12..ccebe1000a6a0bea59a89ec3c0c40f16bf11c1e8 100644
--- a/tests/standalone/src/FileInvalidArgumentsTest.dart
+++ b/tests/standalone/src/FileInvalidArgumentsTest.dart
@@ -88,7 +88,7 @@ class FileTest {
static void testWriteByteInvalidArgs(value) {
String filename = getFilename("tests/vm/data/fixed_length_file");
- var file = (new File(filename + "_out")).openSync(true);
+ var file = (new File(filename + "_out")).openSync(FileMode.WRITE);
try {
file.writeByteSync(value);
Expect.fail('exception expected');
@@ -114,7 +114,7 @@ class FileTest {
static void testWriteListInvalidArgs(buffer, offset, bytes) {
String filename = getFilename("tests/vm/data/fixed_length_file");
- var file = (new File(filename + "_out")).openSync(true);
+ var file = (new File(filename + "_out")).openSync(FileMode.WRITE);
try {
file.writeListSync(buffer, offset, bytes);
Expect.fail('exception expected');
@@ -141,7 +141,7 @@ class FileTest {
static void testWriteStringInvalidArgs(string) {
String filename = getFilename("tests/vm/data/fixed_length_file");
var file = new File(filename + "_out");
- file.openSync(true);
+ file.openSync(FileMode.WRITE);
try {
file.writeString(string);
Expect.fail('exception expected');
« no previous file with comments | « runtime/bin/main.cc ('k') | tests/standalone/src/FileTest.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698