Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 903333002: NaCl cleanup: Remove references to native_client/src/public/nacl_file_info.h (Closed)

Created:
5 years, 10 months ago by Mark Seaborn
Modified:
5 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl cleanup: Remove references to native_client/src/public/nacl_file_info.h It's no longer necessary for the NaCl side to define and refer to the NaClFileToken struct. So we can change the Chromium side to define NaClFileToken, instead of using the definition from nacl_file_info.h. This will let us remove nacl_file_info.h from the NaCl side. We copy the comment from nacl_file_info.h. BUG=https://code.google.com/p/nativeclient/issues/detail?id=4073 TEST=build Committed: https://crrev.com/3faf5be059e1a62895f4ef665f2dc5e628bde4b8 Cr-Commit-Position: refs/heads/master@{#315317}

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M components/nacl/browser/nacl_host_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.h View 1 2 chunks +11 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_validation_db.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_validation_query.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/renderer/plugin/service_runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/nacl/renderer/plugin/service_runtime.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 10 months ago (2015-02-09 15:08:14 UTC) #2
teravest
lgtm
5 years, 10 months ago (2015-02-09 15:17:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903333002/20001
5 years, 10 months ago (2015-02-09 16:08:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-09 16:13:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 16:14:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3faf5be059e1a62895f4ef665f2dc5e628bde4b8
Cr-Commit-Position: refs/heads/master@{#315317}

Powered by Google App Engine
This is Rietveld 408576698