Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 903323002: Revert of Enable libc++ on Android (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, jbudorick+watch_chromium.org, jshin+watch_chromium.org, andrewhsieh, Takashi Toyoshima, Torne, Tom Hudson, danakj, reveman, vmpstr, hans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable libc++ on Android (patchset #16 id:460001 of https://codereview.chromium.org/835633003/) Reason for revert: Slows down the slowest bot on CQ by 20 minutes. BUG=456396 Original issue's description: > Enable libc++ on Android > > Switch Chrome on Android to use libc++ instead of stlport. WebView AOSP > builds will continue to use stlport for the time being. > > Note that this change is exploratory, and likely to be reverted before > branch point (ensuring WebView and Chrome remain in lockstep with > respect to standard library dependencies). > > BUG=427718 > TBR=cpu@chromium.org > > Committed: https://crrev.com/8681920fa22ded465054301ce96657a4ddaf2a04 > Cr-Commit-Position: refs/heads/master@{#315085} TBR=fdegans@chromium.org,pasko@chromium.org,jamesr@chromium.org,thakis@chromium.org,boliu@chromium.org,davidben@chromium.org,cpu@chromium.org,piman@chromium.org,jdduke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=427718 Committed: https://crrev.com/f43ab9ce5b48ed622736d96c9fba9e8fa57858a3 Cr-Commit-Position: refs/heads/master@{#315174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -71 lines) Patch
M android_webview/native/aw_contents.cc View 2 chunks +1 line, -2 lines 0 comments Download
M base/android/jni_array.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M base/containers/hash_tables.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/strings/string_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M build/android/setup.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 6 chunks +18 lines, -18 lines 0 comments Download
M build/config/android/config.gni View 1 chunk +8 lines, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +36 lines, -25 lines 0 comments Download
M net/base/net_util_linux.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/mesa/mesa.gyp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/re2/patches/re2-libcxx.patch View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/re2/util/util.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/run_pie/run_pie.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
Created Revert of Enable libc++ on Android
5 years, 10 months ago (2015-02-07 03:26:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903323002/1
5 years, 10 months ago (2015-02-07 03:26:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-07 03:27:13 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f43ab9ce5b48ed622736d96c9fba9e8fa57858a3 Cr-Commit-Position: refs/heads/master@{#315174}
5 years, 10 months ago (2015-02-07 03:27:57 UTC) #4
jdduke (slow)
5 years, 10 months ago (2015-02-24 16:17:17 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/951983002/ by jdduke@chromium.org.

The reason for reverting is: Android CQ test recipe has switched to release +
dcheck_always_on,
solving the CQ execution time regression..

Powered by Google App Engine
This is Rietveld 408576698