Index: sandbox/linux/suid/client/setuid_sandbox_client.h |
diff --git a/sandbox/linux/suid/client/setuid_sandbox_client.h b/sandbox/linux/suid/client/setuid_sandbox_client.h |
index e6a3e4c5cad2837848c2284d29ab8bc30b742f62..026894fc27b9cc952fb7f65baed48e9c075f14b8 100644 |
--- a/sandbox/linux/suid/client/setuid_sandbox_client.h |
+++ b/sandbox/linux/suid/client/setuid_sandbox_client.h |
@@ -5,28 +5,20 @@ |
#ifndef SANDBOX_LINUX_SUID_SETUID_SANDBOX_CLIENT_H_ |
#define SANDBOX_LINUX_SUID_SETUID_SANDBOX_CLIENT_H_ |
-#include "base/basictypes.h" |
-#include "base/callback_forward.h" |
-#include "base/files/file_path.h" |
-#include "base/files/scoped_file.h" |
-#include "base/process/launch.h" |
+#include "base/environment.h" |
+#include "base/macros.h" |
+#include "base/memory/scoped_ptr.h" |
#include "sandbox/sandbox_export.h" |
namespace sandbox { |
-// Helper class to use the setuid sandbox. This class is to be used both |
-// before launching the setuid helper and after being executed through the |
-// setuid helper. |
+// Helper class to use the setuid sandbox. This class is to be used |
+// after being executed through the setuid helper. |
// This class is difficult to use. It has been created by refactoring very old |
// code scathered through the Chromium code base. |
// |
// A typical use for "A" launching a sandboxed process "B" would be: |
-// 1. A calls SetupLaunchEnvironment() |
-// 2. A sets up a CommandLine and then amends it with |
-// PrependWrapper() (or manually, by relying on GetSandboxBinaryPath()). |
-// 3. A uses SetupLaunchOptions() to arrange for a dummy descriptor for the |
-// setuid sandbox ABI. |
-// 4. A launches B with base::LaunchProcess, using the amended CommandLine. |
+// (Steps 1 through 4 are described in setuid_sandbox_host.h.) |
// 5. B uses CloseDummyFile() to close the dummy file descriptor. |
// 6. B performs various initializations that require access to the file |
// system. |
@@ -37,13 +29,13 @@ namespace sandbox { |
// cannot receive any signal from any other process, excluding SIGKILL. |
// If B dies, all the processes in the namespace will die. |
// B can fork() and the parent can assume the role of init(1), by using |
-// CreateInitProcessReaper(). |
+// sandbox::CreateInitProcessReaper(). |
// 8. B requests being chroot-ed through ChrootMe() and |
// requests other sandboxing status via the status functions. |
class SANDBOX_EXPORT SetuidSandboxClient { |
public: |
// All instantation should go through this factory method. |
- static class SetuidSandboxClient* Create(); |
+ static SetuidSandboxClient* Create(); |
~SetuidSandboxClient(); |
// Close the dummy file descriptor leftover from the sandbox ABI. |
@@ -52,11 +44,6 @@ class SANDBOX_EXPORT SetuidSandboxClient { |
// to an empty directory. |
// Will only work if we have been launched through the setuid helper. |
bool ChrootMe(); |
- // When a new PID namespace is created, the process with pid == 1 should |
- // assume the role of init. |
- // See sandbox/linux/services/init_process_reaper.h for more information |
- // on this API. |
- bool CreateInitProcessReaper(base::Closure* post_fork_parent_callback); |
// Did we get launched through an up to date setuid binary ? |
bool IsSuidSandboxUpToDate() const; |
@@ -69,33 +56,11 @@ class SANDBOX_EXPORT SetuidSandboxClient { |
// Are we done and fully sandboxed ? |
bool IsSandboxed() const; |
- // The setuid sandbox may still be disabled via the environment. |
- // This is tracked in crbug.com/245376. |
- bool IsDisabledViaEnvironment(); |
- // Get the sandbox binary path. This method knows about the |
- // CHROME_DEVEL_SANDBOX environment variable used for user-managed builds. If |
- // the sandbox binary cannot be found, it will return an empty FilePath. |
- base::FilePath GetSandboxBinaryPath(); |
- // Modify |cmd_line| to launch via the setuid sandbox. Crash if the setuid |
- // sandbox binary cannot be found. |cmd_line| must not be NULL. |
- void PrependWrapper(base::CommandLine* cmd_line); |
- // Set-up the launch options for launching via the setuid sandbox. Caller is |
- // responsible for keeping |dummy_fd| alive until LaunchProcess() completes. |
- // |options| and |fds_to_remap| must not be NULL. |
- // (Keeping |dummy_fd| alive is an unfortunate historical artifact of the |
- // chrome-sandbox ABI.) |
- void SetupLaunchOptions(base::LaunchOptions* options, |
- base::FileHandleMappingVector* fds_to_remap, |
- base::ScopedFD* dummy_fd); |
- // Set-up the environment. This should be done prior to launching the setuid |
- // helper. |
- void SetupLaunchEnvironment(); |
- |
private: |
- SetuidSandboxClient(); |
+ explicit SetuidSandboxClient(base::Environment* env); |
// Holds the environment. Will never be NULL. |
- base::Environment* env_; |
+ scoped_ptr<base::Environment> env_; |
bool sandboxed_; |
DISALLOW_COPY_AND_ASSIGN(SetuidSandboxClient); |