Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3026)

Unified Diff: net/url_request/url_request.cc

Issue 903273002: Update from https://crrev.com/315085 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request.h ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 132a67d779898c3f88ee105414cb3a4f915fe09b..d7203a477f148237cc9bffe54833d4dbbe80c37d 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -227,12 +227,6 @@ bool URLRequest::has_upload() const {
return upload_data_stream_.get() != NULL;
}
-void URLRequest::SetExtraRequestHeaderById(int id, const string& value,
- bool overwrite) {
- DCHECK(!is_pending_ || is_redirecting_);
- NOTREACHED() << "implement me!";
-}
-
void URLRequest::SetExtraRequestHeaderByName(const string& name,
const string& value,
bool overwrite) {
@@ -273,6 +267,10 @@ int64 URLRequest::GetTotalReceivedBytes() const {
}
LoadStateWithParam URLRequest::GetLoadState() const {
+ // TODO(pkasting): Remove ScopedTracker below once crbug.com/455952 is
+ // fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("455952 URLRequest::GetLoadState"));
// The !blocked_by_.empty() check allows |this| to report it's blocked on a
// delegate before it has been started.
if (calling_delegate_ || !blocked_by_.empty()) {
@@ -378,11 +376,6 @@ UploadProgress URLRequest::GetUploadProgress() const {
return job_->GetUploadProgress();
}
-void URLRequest::GetResponseHeaderById(int id, string* value) {
- DCHECK(job_.get());
- NOTREACHED() << "implement me!";
-}
-
void URLRequest::GetResponseHeaderByName(const string& name, string* value) {
DCHECK(value);
if (response_info_.headers.get()) {
@@ -392,15 +385,6 @@ void URLRequest::GetResponseHeaderByName(const string& name, string* value) {
}
}
-void URLRequest::GetAllResponseHeaders(string* headers) {
- DCHECK(headers);
- if (response_info_.headers.get()) {
- response_info_.headers->GetNormalizedHeaders(headers);
- } else {
- headers->clear();
- }
-}
-
HostPortPair URLRequest::GetSocketAddress() const {
DCHECK(job_.get());
return job_->GetSocketAddress();
« no previous file with comments | « net/url_request/url_request.h ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698