Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: cc/resources/picture_unittest.cc

Issue 903273002: Update from https://crrev.com/315085 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/picture_pile_unittest.cc ('k') | cc/resources/pixel_buffer_tile_task_worker_pool.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/picture_unittest.cc
diff --git a/cc/resources/picture_unittest.cc b/cc/resources/picture_unittest.cc
index 0c41215549e42d927016e622406ec6efb98022e1..1e2ba44fe3bc0619f45d70f1ce9d2dfa53915792 100644
--- a/cc/resources/picture_unittest.cc
+++ b/cc/resources/picture_unittest.cc
@@ -44,7 +44,7 @@ TEST(PictureTest, AsBase64String) {
scoped_refptr<Picture> one_rect_picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
scoped_ptr<base::Value> serialized_one_rect(one_rect_picture->AsValue());
// Reconstruct the picture.
@@ -66,7 +66,7 @@ TEST(PictureTest, AsBase64String) {
scoped_refptr<Picture> two_rect_picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
scoped_ptr<base::Value> serialized_two_rect(two_rect_picture->AsValue());
@@ -118,7 +118,7 @@ TEST(PictureTest, PixelRefIterator) {
scoped_refptr<Picture> picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, true,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
// Default iterator does not have any pixel refs
{
@@ -213,7 +213,7 @@ TEST(PictureTest, PixelRefIteratorNonZeroLayer) {
scoped_refptr<Picture> picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, true,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
// Default iterator does not have any pixel refs
{
@@ -331,7 +331,7 @@ TEST(PictureTest, PixelRefIteratorOnePixelQuery) {
scoped_refptr<Picture> picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, true,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
for (int y = 0; y < 4; ++y) {
for (int x = 0; x < 4; ++x) {
@@ -374,7 +374,7 @@ TEST(PictureTest, CreateFromSkpValue) {
content_layer_client.add_draw_rect(layer_rect, red_paint);
scoped_refptr<Picture> one_rect_picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
scoped_ptr<base::Value> serialized_one_rect(
one_rect_picture->AsValue());
@@ -406,27 +406,36 @@ TEST(PictureTest, RecordingModes) {
scoped_refptr<Picture> picture =
Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
- Picture::RECORD_NORMALLY);
+ RecordingSource::RECORD_NORMALLY);
EXPECT_TRUE(content_layer_client.last_canvas() != NULL);
- EXPECT_EQ(ContentLayerClient::GRAPHICS_CONTEXT_ENABLED,
- content_layer_client.last_context_status());
+ EXPECT_EQ(ContentLayerClient::PAINTING_BEHAVIOR_NORMAL,
+ content_layer_client.last_painting_control());
EXPECT_TRUE(picture.get());
picture = Picture::Create(layer_rect, &content_layer_client, tile_grid_size,
- false, Picture::RECORD_WITH_SK_NULL_CANVAS);
+ false, RecordingSource::RECORD_WITH_SK_NULL_CANVAS);
EXPECT_TRUE(content_layer_client.last_canvas() != NULL);
- EXPECT_EQ(ContentLayerClient::GRAPHICS_CONTEXT_ENABLED,
- content_layer_client.last_context_status());
+ EXPECT_EQ(ContentLayerClient::PAINTING_BEHAVIOR_NORMAL,
+ content_layer_client.last_painting_control());
EXPECT_TRUE(picture.get());
- picture = Picture::Create(layer_rect, &content_layer_client, tile_grid_size,
- false, Picture::RECORD_WITH_PAINTING_DISABLED);
+ picture =
+ Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
+ RecordingSource::RECORD_WITH_PAINTING_DISABLED);
+ EXPECT_TRUE(content_layer_client.last_canvas() != NULL);
+ EXPECT_EQ(ContentLayerClient::DISPLAY_LIST_CONSTRUCTION_DISABLED,
+ content_layer_client.last_painting_control());
+ EXPECT_TRUE(picture.get());
+
+ picture =
+ Picture::Create(layer_rect, &content_layer_client, tile_grid_size, false,
+ RecordingSource::RECORD_WITH_CACHING_DISABLED);
EXPECT_TRUE(content_layer_client.last_canvas() != NULL);
- EXPECT_EQ(ContentLayerClient::GRAPHICS_CONTEXT_DISABLED,
- content_layer_client.last_context_status());
+ EXPECT_EQ(ContentLayerClient::DISPLAY_LIST_CACHING_DISABLED,
+ content_layer_client.last_painting_control());
EXPECT_TRUE(picture.get());
- EXPECT_EQ(3, Picture::RECORDING_MODE_COUNT);
+ EXPECT_EQ(4, RecordingSource::RECORDING_MODE_COUNT);
}
} // namespace
« no previous file with comments | « cc/resources/picture_pile_unittest.cc ('k') | cc/resources/pixel_buffer_tile_task_worker_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698