Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: net/url_request/url_request.h

Issue 903273002: Update from https://crrev.com/315085 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/udp/udp_socket_win.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index af972bd2df7c15500b429c99b22e16b28bd55f9e..20aab6014a7b82f2cb5da1352b8f1555c2f8a296 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -82,14 +82,6 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
NetworkDelegate* network_delegate,
const std::string& scheme);
- // HTTP request/response header IDs (via some preprocessor fun) for use with
- // SetRequestHeaderById and GetResponseHeaderById.
- enum {
-#define HTTP_ATOM(x) HTTP_ ## x,
-#include "net/http/http_atom_list.h"
-#undef HTTP_ATOM
- };
-
// Referrer policies (see set_referrer_policy): During server redirects, the
// referrer header might be cleared, if the protocol changes from HTTPS to
// HTTP. This is the default behavior of URLRequest, corresponding to
@@ -334,11 +326,9 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// Returns true if the request has a non-empty message body to upload.
bool has_upload() const;
- // Set an extra request header by ID or name, or remove one by name. These
- // methods may only be called before Start() is called, or before a new
- // redirect in the request chain.
- void SetExtraRequestHeaderById(int header_id, const std::string& value,
- bool overwrite);
+ // Set or remove a extra request header. These methods may only be called
+ // before Start() is called, or between receiving a redirect and trying to
+ // follow it.
void SetExtraRequestHeaderByName(const std::string& name,
const std::string& value, bool overwrite);
void RemoveRequestHeaderByName(const std::string& name);
@@ -401,19 +391,13 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// chunked, size is set to zero, but position will not be.
UploadProgress GetUploadProgress() const;
- // Get response header(s) by ID or name. These methods may only be called
+ // Get response header(s) by name. This method may only be called
// once the delegate's OnResponseStarted method has been called. Headers
// that appear more than once in the response are coalesced, with values
// separated by commas (per RFC 2616). This will not work with cookies since
// comma can be used in cookie values.
- // TODO(darin): add API to enumerate response headers.
- void GetResponseHeaderById(int header_id, std::string* value);
void GetResponseHeaderByName(const std::string& name, std::string* value);
- // Get all response headers, \n-delimited and \n\0-terminated. This includes
- // the response status line. Restrictions on GetResponseHeaders apply.
- void GetAllResponseHeaders(std::string* headers);
-
// The time when |this| was constructed.
base::TimeTicks creation_time() const { return creation_time_; }
« no previous file with comments | « net/udp/udp_socket_win.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698