Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: sandbox/linux/suid/client/setuid_sandbox_host_unittest.cc

Issue 903273002: Update from https://crrev.com/315085 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/suid/client/setuid_sandbox_host.cc ('k') | services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/suid/client/setuid_sandbox_host_unittest.cc
diff --git a/sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc b/sandbox/linux/suid/client/setuid_sandbox_host_unittest.cc
similarity index 52%
copy from sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc
copy to sandbox/linux/suid/client/setuid_sandbox_host_unittest.cc
index d4f7dfef32508518a99f1c22d258f59da80c4558..8415abb0643e82c7d409382f8194053f13b09630 100644
--- a/sandbox/linux/suid/client/setuid_sandbox_client_unittest.cc
+++ b/sandbox/linux/suid/client/setuid_sandbox_host_unittest.cc
@@ -1,18 +1,21 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2015 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "sandbox/linux/suid/client/setuid_sandbox_host.h"
+
+#include <string>
+
#include "base/environment.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/strings/string_number_conversions.h"
-#include "sandbox/linux/suid/client/setuid_sandbox_client.h"
#include "sandbox/linux/suid/common/sandbox.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace sandbox {
-TEST(SetuidSandboxClient, SetupLaunchEnvironment) {
+TEST(SetuidSandboxHost, SetupLaunchEnvironment) {
const char kTestValue[] = "This is a test";
scoped_ptr<base::Environment> env(base::Environment::Create());
EXPECT_TRUE(env != NULL);
@@ -25,15 +28,14 @@ TEST(SetuidSandboxClient, SetupLaunchEnvironment) {
EXPECT_TRUE(env->SetVar("LD_PRELOAD", kTestValue));
EXPECT_TRUE(env->UnSetVar("LD_ORIGIN_PATH"));
- scoped_ptr<SetuidSandboxClient>
- sandbox_client(SetuidSandboxClient::Create());
- EXPECT_TRUE(sandbox_client != NULL);
+ scoped_ptr<SetuidSandboxHost> sandbox_host(SetuidSandboxHost::Create());
+ EXPECT_TRUE(sandbox_host != NULL);
// Make sure the environment is clean.
EXPECT_TRUE(env->UnSetVar(kSandboxEnvironmentApiRequest));
EXPECT_TRUE(env->UnSetVar(kSandboxEnvironmentApiProvides));
- sandbox_client->SetupLaunchEnvironment();
+ sandbox_host->SetupLaunchEnvironment();
// Check if the requested API environment was set.
std::string api_request;
@@ -59,43 +61,12 @@ TEST(SetuidSandboxClient, SetupLaunchEnvironment) {
}
}
-TEST(SetuidSandboxClient, SandboxedClientAPI) {
- scoped_ptr<base::Environment> env(base::Environment::Create());
- EXPECT_TRUE(env != NULL);
-
- scoped_ptr<SetuidSandboxClient>
- sandbox_client(SetuidSandboxClient::Create());
- EXPECT_TRUE(sandbox_client != NULL);
-
- // Set-up a fake environment as if we went through the setuid sandbox.
- EXPECT_TRUE(env->SetVar(kSandboxEnvironmentApiProvides,
- base::IntToString(kSUIDSandboxApiNumber)));
- EXPECT_TRUE(env->SetVar(kSandboxDescriptorEnvironmentVarName, "1"));
- EXPECT_TRUE(env->SetVar(kSandboxPIDNSEnvironmentVarName, "1"));
- EXPECT_TRUE(env->UnSetVar(kSandboxNETNSEnvironmentVarName));
-
- // Check the API.
- EXPECT_TRUE(sandbox_client->IsSuidSandboxUpToDate());
- EXPECT_TRUE(sandbox_client->IsSuidSandboxChild());
- EXPECT_TRUE(sandbox_client->IsInNewPIDNamespace());
- EXPECT_FALSE(sandbox_client->IsInNewNETNamespace());
-
- // Forge an incorrect API version and check.
- EXPECT_TRUE(env->SetVar(kSandboxEnvironmentApiProvides,
- base::IntToString(kSUIDSandboxApiNumber + 1)));
- EXPECT_FALSE(sandbox_client->IsSuidSandboxUpToDate());
- // We didn't go through the actual sandboxing mechanism as it is
- // very hard in a unit test.
- EXPECT_FALSE(sandbox_client->IsSandboxed());
-}
-
// This test doesn't accomplish much, but will make sure that analysis tools
// will run this codepath.
-TEST(SetuidSandboxClient, GetSandboxBinaryPath) {
- scoped_ptr<SetuidSandboxClient> setuid_sandbox_client(
- SetuidSandboxClient::Create());
- ignore_result(setuid_sandbox_client->GetSandboxBinaryPath());
+TEST(SetuidSandboxHost, GetSandboxBinaryPath) {
+ scoped_ptr<SetuidSandboxHost> setuid_sandbox_host(
+ SetuidSandboxHost::Create());
+ ignore_result(setuid_sandbox_host->GetSandboxBinaryPath());
}
} // namespace sandbox
-
« no previous file with comments | « sandbox/linux/suid/client/setuid_sandbox_host.cc ('k') | services/surfaces/surfaces_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698