Issue 903263002: Delete old-school AppBannerViews

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 903263002: Delete old-school AppBannerViews (Closed)

Created:
5 years, 10 months ago by gone

Modified:
5 years, 10 months ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Delete old-school AppBannerViews The public hardly knew ye. Replaced by AppBannerInfoBars. BUG=453170 Committed: https://crrev.com/9f8c7a6ea06853b758f2b6944aa1085d1837a577 Cr-Commit-Position: refs/heads/master@{#315137}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -947 lines)			Patch
D	chrome/android/java/res/drawable-xxhdpi/card_background_default.9.png	View	Binary file		0 comments	Download
D	chrome/android/java/res/layout/app_banner_view.xml	View	1 chunk	+0 lines, -92 lines	0 comments	Download
D	chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerView.java	View	1 chunk	+0 lines, -855 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903263002/1

5 years, 10 months ago (2015-02-06 23:13:25 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 23:52:58 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9f8c7a6ea06853b758f2b6944aa1085d1837a577
Cr-Commit-Position: refs/heads/master@{#315137}