Reduce number of includes in CSSPropertyParser

Reduce number of includes in CSSPropertyParser

Reduce the dependency of CSSPropertyParser on other files.

BUG=404023
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189902

[rwlbuis, 2015-02-09 18:47:00]

rob.buis@samsung.com changed reviewers:
+ esprehn@chromium.org

[rwlbuis, 2015-02-09 18:47:00]

PTAL. Looks like it can be further reduced by enum classes in some cases...

[Timothy Loh, 2015-02-10 00:02:53]

On 2015/02/09 18:47:00, rwlbuis wrote:
> PTAL. Looks like it can be further reduced by enum classes in some cases...

lgtm

[rwlbuis, 2015-02-10 00:40:31]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-02-10 00:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/903253002/1

[commit-bot: I haz the power, 2015-02-10 01:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-10 01:58:35]

Failed to apply patch for Source/core/css/parser/CSSPropertyParser.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/parser/CSSPropertyParser.cpp
  Hunk #2 FAILED at 37.
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/parser/CSSPropertyParser.cpp.rej

Patch:       Source/core/css/parser/CSSPropertyParser.cpp
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp
b/Source/core/css/parser/CSSPropertyParser.cpp
index
539ad6ed8b536633969c16a67cce948d565f22a6..0e88ce9e17e1c896bb233e002fd571d521a48cb3
100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -27,8 +27,6 @@
 #include "config.h"
 #include "core/css/parser/CSSPropertyParser.h"
 
-// FIXME: Way too many!
-#include "core/CSSValueKeywords.h"
 #include "core/StylePropertyShorthand.h"
 #include "core/css/CSSBasicShapes.h"
 #include "core/css/CSSBorderImage.h"
@@ -39,52 +37,33 @@
 #include "core/css/CSSFontFaceSrcValue.h"
 #include "core/css/CSSFontFeatureValue.h"
 #include "core/css/CSSFunctionValue.h"
-#include "core/css/CSSGradientValue.h"
 #include "core/css/CSSGridLineNamesValue.h"
-#include "core/css/CSSGridTemplateAreasValue.h"
 #include "core/css/CSSImageSetValue.h"
 #include "core/css/CSSImageValue.h"
-#include "core/css/CSSInheritedValue.h"
-#include "core/css/CSSInitialValue.h"
-#include "core/css/CSSKeyframeRule.h"
-#include "core/css/CSSKeyframesRule.h"
 #include "core/css/CSSLineBoxContainValue.h"
 #include "core/css/CSSPathValue.h"
-#include "core/css/CSSPrimitiveValue.h"
 #include "core/css/CSSPrimitiveValueMappings.h"
+#include "core/css/CSSProperty.h"
 #include "core/css/CSSPropertyMetadata.h"
-#include "core/css/CSSPropertySourceData.h"
 #include "core/css/CSSReflectValue.h"
 #include "core/css/CSSSVGDocumentValue.h"
-#include "core/css/CSSSelector.h"
 #include "core/css/CSSShadowValue.h"
 #include "core/css/CSSTimingFunctionValue.h"
 #include "core/css/CSSTransformValue.h"
 #include "core/css/CSSUnicodeRangeValue.h"
-#include "core/css/CSSValueList.h"
 #include "core/css/CSSValuePool.h"
 #include "core/css/Counter.h"
 #include "core/css/HashTools.h"
 #include "core/css/Pair.h"
 #include "core/css/Rect.h"
 #include "core/css/parser/CSSParserFastPaths.h"
-#include "core/css/parser/CSSParserIdioms.h"
 #include "core/css/parser/CSSParserValues.h"
 #include "core/frame/UseCounter.h"
 #include "core/html/parser/HTMLParserIdioms.h"
-#include "core/inspector/InspectorInstrumentation.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/rendering/style/GridCoordinate.h"
 #include "core/svg/SVGPathUtilities.h"
-#include "platform/FloatConversion.h"
 #include "platform/RuntimeEnabledFeatures.h"
-#include "wtf/BitArray.h"
-#include "wtf/HexNumber.h"
-#include "wtf/text/StringBuffer.h"
-#include "wtf/text/StringBuilder.h"
-#include "wtf/text/StringImpl.h"
-#include "wtf/text/TextEncoding.h"
-#include <limits.h>
 
 namespace blink {

[rwlbuis, 2015-02-10 13:56:18]

New patchsets have been uploaded after l-g-t-m from timloh@chromium.org

[rwlbuis, 2015-02-10 14:20:13]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-02-10 14:20:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/903253002/20001

[commit-bot: I haz the power, 2015-02-10 15:35:19]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189902