Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 903183003: X87: Remove the dependency of Zone on Isolate (Closed)

Created:
5 years, 10 months ago by chunyang.dai
Modified:
5 years, 10 months ago
Reviewers:
Weiliang, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Remove the dependency of Zone on Isolate port c7b09aac317dd810d29b82061973199b80363b65 (r26252) original commit message: Along the way: - Thread isolate parameter explicitly through code that used to rely on getting it from the zone. - Canonicalize the parameter position of isolate and zone for affected code - Change Hydrogen New<> instruction templates to automatically pass isolate BUG= R=weiliang.lin@intel.com Committed: https://chromium.googlesource.com/v8/v8/+/3c56b026743808157129a32c6eb4a7d7d5d3ecbc

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/x87/regexp-macro-assembler-x87.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/regexp-macro-assembler-x87.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL. thanks
5 years, 10 months ago (2015-02-07 06:10:08 UTC) #2
Weiliang
lgtm
5 years, 10 months ago (2015-02-07 06:19:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903183003/20001
5 years, 10 months ago (2015-02-07 06:20:03 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3c56b026743808157129a32c6eb4a7d7d5d3ecbc Cr-Commit-Position: refs/heads/master@{#26501}
5 years, 10 months ago (2015-02-07 06:22:56 UTC) #6
chunyang.dai
5 years, 10 months ago (2015-02-07 06:23:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3c56b026743808157129a32c6eb4a7d7d5d3ecbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698