Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 903153002: Install android test certificate authority when host supports SNI (Closed)

Created:
5 years, 10 months ago by slamm
Modified:
5 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Install android test certificate authority when host supports SNI (pyOpenSSL 0.13 or greater). This relands https://crrev.com/855603002/, "Roll Web Page Replay to pick-up HTTPS certificate fixes," and picks-up one additional Web Page Replay change to test for SNI support. BUG=431686 Committed: https://crrev.com/30c0674334fb28622eb0b5289d22e66822c849cf Cr-Commit-Position: refs/heads/master@{#315333}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update certutils mock for unit test. #

Patch Set 3 : Add TODO to move cert creation (certutils calls) to webpagereplay.py. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 1 2 2 chunks +13 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
slamm
I have a try job pending to test the previously failing test. https://codereview.chromium.org/904973003/ http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect Additionally, ...
5 years, 10 months ago (2015-02-06 19:01:38 UTC) #2
nednguyen
https://codereview.chromium.org/903153002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/903153002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode445 tools/telemetry/telemetry/core/platform/android_platform_backend.py:445: if not certutils.has_sni(): Please add a TODO to move ...
5 years, 10 months ago (2015-02-06 19:09:44 UTC) #3
slamm
Update certutils mock for unit test.
5 years, 10 months ago (2015-02-06 19:18:36 UTC) #4
slamm
Add TODO to move cert creation (certutils calls) to webpagereplay.py.
5 years, 10 months ago (2015-02-06 19:25:36 UTC) #5
slamm
I also updated "CertUtilsStub" for the android_platform_backend unit test. https://codereview.chromium.org/903153002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/903153002/diff/1/tools/telemetry/telemetry/core/platform/android_platform_backend.py#newcode445 tools/telemetry/telemetry/core/platform/android_platform_backend.py:445: ...
5 years, 10 months ago (2015-02-06 19:26:57 UTC) #6
nednguyen
lgtm
5 years, 10 months ago (2015-02-06 19:28:46 UTC) #7
sullivan
On 2015/02/06 19:28:46, nednguyen wrote: > lgtm lgtm too, but can you hold off on ...
5 years, 10 months ago (2015-02-06 19:32:04 UTC) #8
chromium-reviews
Monday is fine. On Fri, Feb 6, 2015 at 11:32 AM, <sullivan@chromium.org> wrote: > On ...
5 years, 10 months ago (2015-02-06 19:39:49 UTC) #9
slamm
On 2015/02/06 19:32:04, sullivan wrote: > On 2015/02/06 19:28:46, nednguyen wrote: > > lgtm > ...
5 years, 10 months ago (2015-02-06 19:41:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903153002/40001
5 years, 10 months ago (2015-02-09 17:24:05 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 17:29:26 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 17:30:11 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/30c0674334fb28622eb0b5289d22e66822c849cf
Cr-Commit-Position: refs/heads/master@{#315333}

Powered by Google App Engine
This is Rietveld 408576698