Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 903123002: Allow printerProvider API services in incognito (Closed)

Created:
5 years, 10 months ago by tbarzic
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow printerProvider API services in incognito BUG=455999 TEST=Chrome does not crash when changing selected printer in print preview opened in an incognito window Committed: https://crrev.com/86b3295d6ac8d5f6f947861ac9c2d6fa51479781 Cr-Commit-Position: refs/heads/master@{#315074}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M extensions/browser/api/printer_provider/printer_provider_api.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
5 years, 10 months ago (2015-02-06 17:35:38 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 10 months ago (2015-02-06 17:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903123002/1
5 years, 10 months ago (2015-02-06 17:52:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 18:31:55 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:32:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86b3295d6ac8d5f6f947861ac9c2d6fa51479781
Cr-Commit-Position: refs/heads/master@{#315074}

Powered by Google App Engine
This is Rietveld 408576698