Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 903113003: Adding the orphaned options pages to the navigation (Closed)

Created:
5 years, 10 months ago by mkearney1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding the orphaned options pages to the navigation Committed: https://crrev.com/060defde33dc37aaeec74181b461162e194d131f Cr-Commit-Position: refs/heads/master@{#315097}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/common/extensions/docs/templates/json/chrome_sidenav.json View 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
mkearney1
Ben, I checked that the left-side navigation appears for these pages once added. It's not ...
5 years, 10 months ago (2015-02-06 19:10:56 UTC) #2
not at google - send to devlin
lgtm https://codereview.chromium.org/903113003/diff/1/chrome/common/extensions/docs/templates/json/chrome_sidenav.json File chrome/common/extensions/docs/templates/json/chrome_sidenav.json (right): https://codereview.chromium.org/903113003/diff/1/chrome/common/extensions/docs/templates/json/chrome_sidenav.json#newcode621 chrome/common/extensions/docs/templates/json/chrome_sidenav.json:621: "title": "Options", I would say "Options (Traditional)" and ...
5 years, 10 months ago (2015-02-06 19:40:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903113003/1
5 years, 10 months ago (2015-02-06 19:43:42 UTC) #5
not at google - send to devlin
not lgtm I had a comment
5 years, 10 months ago (2015-02-06 19:47:23 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 20:29:01 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 20:29:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/060defde33dc37aaeec74181b461162e194d131f
Cr-Commit-Position: refs/heads/master@{#315097}

Powered by Google App Engine
This is Rietveld 408576698