Chromecast: change BrowserCdmCast threading model.

Chromecast: change BrowserCdmCast threading model.

Per crbug/444930 discussion, BrowserCdm should generally remain on UI
thread. Interactions between the CMA pipeline and BrowserCdm should
remain thread-safe.

R=erickung@chromium.org,lcwu@chromium.org

Committed: https://crrev.com/2567caca45d545c21cd81c7cb42edd29a4c68515
Cr-Commit-Position: refs/heads/master@{#315359}

[erickung1, 2015-02-07 01:31:10]

lgtm % nit comments

BTW, I searched the code and PlayerTrackerImpl is still used by Android. what's
the plan on Android cast shell?

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:12: BrowserCdmCast::BrowserCdmCast() {
|next_registration_id_| initialization?

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:16: {
Nit: maybe no need the parentheses?

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:54: {
Nit: maybe no need the parentheses?

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cma/pipelin...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cma/pipelin...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:116:
DCHECK(thread_checker_.CalledOnValidThread());
Very NIT: may switch line with CMALOG to follow other function implementation

[gunsch, 2015-02-07 01:44:06]

New patchsets have been uploaded after l-g-t-m from erickung@chromium.org

[gunsch, 2015-02-07 01:44:27]

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
File chromecast/media/cdm/browser_cdm_cast.cc (right):

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:12: BrowserCdmCast::BrowserCdmCast() {
On 2015/02/07 01:31:10, erickung1 wrote:
> |next_registration_id_| initialization?

Done.

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:16: {
On 2015/02/07 01:31:10, erickung1 wrote:
> Nit: maybe no need the parentheses?

Done.

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cdm/browser...
chromecast/media/cdm/browser_cdm_cast.cc:54: {
On 2015/02/07 01:31:10, erickung1 wrote:
> Nit: maybe no need the parentheses?

Done.

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cma/pipelin...
File chromecast/media/cma/pipeline/media_pipeline_impl.cc (right):

https://codereview.chromium.org/903083003/diff/1/chromecast/media/cma/pipelin...
chromecast/media/cma/pipeline/media_pipeline_impl.cc:116:
DCHECK(thread_checker_.CalledOnValidThread());
On 2015/02/07 01:31:10, erickung1 wrote:
> Very NIT: may switch line with CMALOG to follow other function implementation

Done.

[lcwu1, 2015-02-09 19:06:43]

lgtm

[gunsch, 2015-02-09 19:08:35]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2015-02-09 19:09:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/903083003/20001

[commit-bot: I haz the power, 2015-02-09 19:13:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-09 19:14:26]

Patchset 2 (id:??) landed as
https://crrev.com/2567caca45d545c21cd81c7cb42edd29a4c68515
Cr-Commit-Position: refs/heads/master@{#315359}