Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 903073003: Revert "Adding q=low to the Chrome-Proxy request header" (Closed)

Created:
5 years, 10 months ago by apavlov
Modified:
5 years, 10 months ago
Reviewers:
megjablon
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Adding q=low to the Chrome-Proxy request header" Speculatively revert https://codereview.chromium.org/791493015 due to multiple browser_tests failures (e.g. see https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/15751) They are all due to SystemURLRequestContextGetter-related leaks. This reverts commit 8fbff4fad29b9e2408c634e178386d456acf6467. TBR=megjablon NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456110 Committed: https://crrev.com/adb1d7096d2c2da9a5843edc718378663587ef91 Cr-Commit-Position: refs/heads/master@{#315031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -1188 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 2 chunks +1 line, -1 line 0 comments Download
M components/data_reduction_proxy.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 4 chunks +3 lines, -3 lines 0 comments Download
A + components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.h View 8 chunks +21 lines, -43 lines 0 comments Download
A + components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler.cc View 11 chunks +37 lines, -83 lines 0 comments Download
A components/data_reduction_proxy/core/browser/data_reduction_proxy_auth_request_handler_unittest.cc View 1 chunk +322 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_interceptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 3 chunks +4 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.h View 1 chunk +0 lines, -195 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options.cc View 1 chunk +0 lines, -296 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_request_options_unittest.cc View 1 chunk +0 lines, -478 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
apavlov
5 years, 10 months ago (2015-02-06 14:30:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903073003/1
5 years, 10 months ago (2015-02-06 14:34:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 14:35:55 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 14:37:01 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/adb1d7096d2c2da9a5843edc718378663587ef91
Cr-Commit-Position: refs/heads/master@{#315031}

Powered by Google App Engine
This is Rietveld 408576698