Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 903013002: Landing Recent QUIC Changes. (Closed)

Created:
5 years, 10 months ago by ramant (doing other things)
Modified:
5 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC Changes. Making the (deprecation-in-progress) congestion field write only. This is a bit of a hack because technically it's "required" for QUIC_VERSION_23 but as all the internal servers and all of chrome builds picking up this change consider the field optional despite the version, it should just Work (TM). I was hoping to stop sending the congestion fields for v24 clients but that is not safe until the internal server fleet doesn't consider it a required field for negotiated()=true. Bah. No longer reading the (deprecated) congestion fields for QUIC. Merge internal change: 85158634 https://codereview.chromium.org/898233003/ Improving junk packet handling for QUIC by ignoring packets with client port 0. Merge internal change: 85067984 https://codereview.chromium.org/885713009/ Removing deprecated flag FLAGS_quic_use_initial_rtt_for_stats. Merge internal change: 84999682 https://codereview.chromium.org/883393008/ Adding more error logging for failed QUIC writes. Merge internal change: 84989992 https://codereview.chromium.org/898243002/ Further cleanup to QuicAckNotifier and QuicAckNotifierManager. No functional change. Merge internal change: 84784925 https://codereview.chromium.org/880403006/ Remove an unneeded hash_set from QuicAckNotifierManager. No change in behavior. Merge internal change: 84637544 https://codereview.chromium.org/872403007/ Minor cleanup and optimization of QuicConnection::IsConnectionClose. Merge internal change: 84624803 https://codereview.chromium.org/903973002/ Rename QuicAckNotifier's AddSequenceNumber to OnSerializedPacket. No functional change. Merge internal change: 84624660 https://codereview.chromium.org/867293004/ R=rch@chromium.org Committed: https://crrev.com/ff331b65e0aef293ed6f1d0954b83ae17cc66d28 Cr-Commit-Position: refs/heads/master@{#315086} Committed: https://crrev.com/e6f0c87c4248a1dd48956cf81c2ef56c21ff27db Cr-Commit-Position: refs/heads/master@{#315115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -143 lines) Patch
M net/quic/quic_ack_notifier.h View 1 chunk +14 lines, -14 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.h View 1 chunk +1 line, -9 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 4 chunks +16 lines, -20 lines 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 4 chunks +23 lines, -14 lines 0 comments Download
M net/quic/quic_config.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M net/quic/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_connection.cc View 5 chunks +25 lines, -28 lines 0 comments Download
M net/quic/quic_dispatcher.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_config_peer.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +47 lines, -30 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
ramant (doing other things)
5 years, 10 months ago (2015-02-06 05:20:24 UTC) #1
Ryan Hamilton
lgtm
5 years, 10 months ago (2015-02-06 19:11:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903013002/1
5 years, 10 months ago (2015-02-06 19:32:14 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 19:35:43 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ff331b65e0aef293ed6f1d0954b83ae17cc66d28 Cr-Commit-Position: refs/heads/master@{#315086}
5 years, 10 months ago (2015-02-06 19:36:13 UTC) #6
ramant (doing other things)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/908623002/ by rtenneti@chromium.org. ...
5 years, 10 months ago (2015-02-06 20:02:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/903013002/1
5 years, 10 months ago (2015-02-06 21:52:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 21:53:55 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 21:54:39 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6f0c87c4248a1dd48956cf81c2ef56c21ff27db
Cr-Commit-Position: refs/heads/master@{#315115}

Powered by Google App Engine
This is Rietveld 408576698