Issue 9030028: Issue 1039: Nested comments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9030028: Issue 1039: Nested comments (Closed)

Created:
8 years, 11 months ago by codefu

Modified:
8 years, 11 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Issue 1039: Nested comments http://code.google.com/p/dart/issues/detail?id=1039 Language Specification 0.06, 14.1.2 specifices that multiline comments can nest: MULTI LINE COMMENT: ‘/*’ (MULTI LINE COMMENT | ̃ ‘*/’)* ‘*/’ ; R=zundel BUG=1039 TEST= Committed: https://code.google.com/p/dart/source/detail?r=2964

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -6 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartScanner.java	View		1 chunk	+11 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/CommentTest.java	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/Comments.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/language/src/NestedCommentsTest.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

zundel

I don't see a bug, but I think you should add tests to com.google.dart.compiler.parser.CommentsTest to ...

8 years, 11 months ago (2012-01-04 19:17:08 UTC) #2

codefu

On 2012/01/04 19:17:08, zundel wrote: > I don't see a bug, but I think you ...

8 years, 11 months ago (2012-01-04 19:23:24 UTC) #3

lgtm