Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 902973002: Update {virtual,override,final} to follow C++11 style in device. (Closed)

Created:
5 years, 10 months ago by dcheng
Modified:
5 years, 10 months ago
Reviewers:
timvolodine
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in device. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with an OS=android build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=timvolodine@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/809e023343ae13d40f21e4d03ff7b09b5ecf005a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/vibration/vibration_manager_impl_android.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 10 months ago (2015-02-06 00:59:57 UTC) #2
timvolodine
lgtm
5 years, 10 months ago (2015-02-06 14:37:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902973002/1
5 years, 10 months ago (2015-02-06 18:40:49 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/809e023343ae13d40f21e4d03ff7b09b5ecf005a Cr-Commit-Position: refs/heads/master@{#315079}
5 years, 10 months ago (2015-02-06 19:03:28 UTC) #6
dcheng
5 years, 10 months ago (2015-02-06 19:03:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
809e023343ae13d40f21e4d03ff7b09b5ecf005a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698