Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 902873002: Reimplement gpu message bus for invalidated bitmap gen IDs (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@one_tex
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reimplement gpu message bus for invalidated bitmap gen IDs Committed: https://skia.googlesource.com/skia/+/23e619cf462b2a8a500f3ca750e099f79601f508

Patch Set 1 #

Patch Set 2 : stuff #

Patch Set 3 : whitespace #

Total comments: 1

Patch Set 4 : fix speeling error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -126 lines) Patch
M include/core/SkTArray.h View 1 3 chunks +22 lines, -5 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrResourceKey.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M include/gpu/SkGr.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/core/SkMessageBus.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M src/gpu/GrGpuResourceCacheAccess.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache2.h View 1 2 6 chunks +30 lines, -8 lines 0 comments Download
M src/gpu/GrResourceCache2.cpp View 1 2 3 chunks +19 lines, -1 line 0 comments Download
M src/gpu/SkGr.cpp View 1 14 chunks +46 lines, -43 lines 0 comments Download
M tests/MessageBusTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 11 chunks +60 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
bsalomon
5 years, 10 months ago (2015-02-06 16:48:06 UTC) #2
robertphillips
lgtm + a nit https://codereview.chromium.org/902873002/diff/40001/tests/ResourceCacheTest.cpp File tests/ResourceCacheTest.cpp (right): https://codereview.chromium.org/902873002/diff/40001/tests/ResourceCacheTest.cpp#newcode681 tests/ResourceCacheTest.cpp:681: their ?
5 years, 10 months ago (2015-02-06 19:38:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902873002/60001
5 years, 10 months ago (2015-02-06 19:46:33 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 19:54:33 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/23e619cf462b2a8a500f3ca750e099f79601f508

Powered by Google App Engine
This is Rietveld 408576698