Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 902853002: Grokdump workaround for different layout of *_LIST structures written to minidumps on Mac. (Closed)

Created:
5 years, 10 months ago by Igor Sheludko
Modified:
5 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Grokdump workaround for different layout of *_LIST structures written to minidumps on Mac. Committed: https://crrev.com/21b2ea80f7b48f91cc823b133a5c3978b1bb6742 Cr-Commit-Position: refs/heads/master@{#26456}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M tools/grokdump.py View 5 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTALnC
5 years, 10 months ago (2015-02-05 11:13:00 UTC) #3
Jakob Kummerow
LGTM if it also works on 32-bit Mac dumps.
5 years, 10 months ago (2015-02-05 11:21:47 UTC) #4
Igor Sheludko
Yes, it works. 32-bit dumps seem to have good 32-bit layout.
5 years, 10 months ago (2015-02-05 11:26:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902853002/20001
5 years, 10 months ago (2015-02-05 11:27:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-05 11:47:08 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 11:47:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21b2ea80f7b48f91cc823b133a5c3978b1bb6742
Cr-Commit-Position: refs/heads/master@{#26456}

Powered by Google App Engine
This is Rietveld 408576698