Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 902813003: Temporarily remove DCHECK that triggers during hardware teardown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More speculative changes Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/browser_view_renderer.cc
diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc
index 1ccfc112761befe5d4b0d6593de4c43aa8bbb089..32435bf68c882896d4edfdc4652f99f39fd3b1a5 100644
--- a/android_webview/browser/browser_view_renderer.cc
+++ b/android_webview/browser/browser_view_renderer.cc
@@ -379,8 +379,8 @@ void BrowserViewRenderer::OnAttachedToWindow(int width, int height) {
void BrowserViewRenderer::OnDetachedFromWindow() {
TRACE_EVENT0("android_webview", "BrowserViewRenderer::OnDetachedFromWindow");
- shared_renderer_state_.ReleaseHardwareDrawIfNeededOnUI();
attached_to_window_ = false;
+ shared_renderer_state_.ReleaseHardwareDrawIfNeededOnUI();
DCHECK(!hardware_enabled_);
}
@@ -399,7 +399,7 @@ void BrowserViewRenderer::ReleaseHardware() {
bool BrowserViewRenderer::IsVisible() const {
// Ignore |window_visible_| if |attached_to_window_| is false.
- return view_visible_ && (!attached_to_window_ || window_visible_);
+ return view_visible_ && attached_to_window_ && window_visible_;
}
gfx::Rect BrowserViewRenderer::GetScreenRect() const {
« no previous file with comments | « no previous file | android_webview/browser/shared_renderer_state.cc » ('j') | android_webview/browser/shared_renderer_state.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698