win: Fixes for minidump_misc_info_writer_test.cc

snapshot/test/test_process_snapshot.h

Index: snapshot/test/test_process_snapshot.h
diff --git a/snapshot/test/test_process_snapshot.h b/snapshot/test/test_process_snapshot.h
index 25550ccca6c14a8639e49be9625f1fa70403a491..890ca5aa256460d358cc6ca12fa9b743735c902b 100644
--- a/snapshot/test/test_process_snapshot.h
+++ b/snapshot/test/test_process_snapshot.h
@@ -24,15 +24,14 @@
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "snapshot/exception_snapshot.h"
+#include "snapshot/module_snapshot.h"

[Mark Mentovai, 2015/02/05 14:48:36]

You can remove the #includes for module_snapshot.h and thread_snapshot.h from
test_process_snapshot.cc, since they’re in this file now.

[scottmg, 2015/02/05 17:24:52]

Done.

 #include "snapshot/process_snapshot.h"
 #include "snapshot/system_snapshot.h"
+#include "snapshot/thread_snapshot.h"
 #include "util/stdlib/pointer_container.h"
 
 namespace crashpad {
 

[Mark Mentovai, 2015/02/05 14:48:36]

You can get rid of this blank line too, since there’s no longer any intervening
stuff in this file that’s in crashpad but not crashpad::test.

[scottmg, 2015/02/05 17:24:52]

Done.

-class ModuleSnapshot;
-class ThreadSnapshot;
-
 namespace test {
 
 //! \brief A test ProcessSnapshot that can carry arbitrary data for testing