win: Fixes for minidump_misc_info_writer_test.cc

win: Fixes for minidump_misc_info_writer_test.cc

test_process_snapshot.h apparently requires the full inclusion,
not a forward declaration otherwise it claims to be deleting
undefined types.

And, some more potentially uninitialized variables.

R=mark@chromium.org
BUG=crashpad:1
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/a813dd2e1b88986098fe01dee8940fdf2ea68e1d

[scottmg, 2015-02-05 06:19:59]

scottmg@chromium.org changed reviewers:
+ mark@chromium.org

[scottmg, 2015-02-05 06:20:07]

oops, forgot R=

[Mark Mentovai, 2015-02-05 14:48:36]

LGTM

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
File snapshot/test/test_process_snapshot.h (right):

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:27: #include "snapshot/module_snapshot.h"
You can remove the #includes for module_snapshot.h and thread_snapshot.h from
test_process_snapshot.cc, since they’re in this file now.

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:34: 
You can get rid of this blank line too, since there’s no longer any intervening
stuff in this file that’s in crashpad but not crashpad::test.

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:70: void
AddThread(scoped_ptr<ThreadSnapshot> thread) {
These scoped_ptr<> arguments are why the forward declarations weren’t enough.

[scottmg, 2015-02-05 17:24:28]

New patchsets have been uploaded after l-g-t-m from mark@chromium.org

[scottmg, 2015-02-05 17:24:52]

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
File snapshot/test/test_process_snapshot.h (right):

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:27: #include "snapshot/module_snapshot.h"
On 2015/02/05 14:48:36, Mark Mentovai wrote:
> You can remove the #includes for module_snapshot.h and thread_snapshot.h from
> test_process_snapshot.cc, since they’re in this file now.

Done.

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:34: 
On 2015/02/05 14:48:36, Mark Mentovai wrote:
> You can get rid of this blank line too, since there’s no longer any
intervening
> stuff in this file that’s in crashpad but not crashpad::test.

Done.

https://codereview.chromium.org/902803002/diff/1/snapshot/test/test_process_s...
snapshot/test/test_process_snapshot.h:70: void
AddThread(scoped_ptr<ThreadSnapshot> thread) {
On 2015/02/05 14:48:36, Mark Mentovai wrote:
> These scoped_ptr<> arguments are why the forward declarations weren’t enough.

Right. I noticed the members and out-of-line destructor, but missed the
arguments here.

[scottmg, 2015-02-05 17:25:18]

Committed patchset #2 (id:20001) manually as
a813dd2e1b88986098fe01dee8940fdf2ea68e1d (presubmit successful).