Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: minidump/minidump_crashpad_info_writer_test.cc

Issue 902793003: win: potentially uninitialized variables in minidump_crashpad_info_writer_test.cc (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_test-14
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_crashpad_info_writer_test.cc
diff --git a/minidump/minidump_crashpad_info_writer_test.cc b/minidump/minidump_crashpad_info_writer_test.cc
index cff50f52d165009f09b69f3dcb0d7921f6a2af43..1c775214bae6159cb49c1980b86966136f89fb94 100644
--- a/minidump/minidump_crashpad_info_writer_test.cc
+++ b/minidump/minidump_crashpad_info_writer_test.cc
@@ -62,8 +62,8 @@ TEST(MinidumpCrashpadInfoWriter, Empty) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MinidumpCrashpadInfo* crashpad_info;
- const MinidumpModuleCrashpadInfoList* module_list;
+ const MinidumpCrashpadInfo* crashpad_info = nullptr;
+ const MinidumpModuleCrashpadInfoList* module_list = nullptr;
ASSERT_NO_FATAL_FAILURE(GetCrashpadInfoStream(
file_writer.string(), &crashpad_info, &module_list));
@@ -92,7 +92,7 @@ TEST(MinidumpCrashpadInfoWriter, CrashpadModuleList) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MinidumpCrashpadInfo* crashpad_info;
+ const MinidumpCrashpadInfo* crashpad_info = nullptr;
const MinidumpModuleCrashpadInfoList* module_list;
ASSERT_NO_FATAL_FAILURE(GetCrashpadInfoStream(
@@ -147,7 +147,7 @@ TEST(MinidumpCrashpadInfoWriter, InitializeFromSnapshot) {
StringFileWriter file_writer;
ASSERT_TRUE(minidump_file_writer.WriteEverything(&file_writer));
- const MinidumpCrashpadInfo* info;
+ const MinidumpCrashpadInfo* info = nullptr;
const MinidumpModuleCrashpadInfoList* module_list;
ASSERT_NO_FATAL_FAILURE(GetCrashpadInfoStream(
file_writer.string(), &info, &module_list));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698