Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 902783006: Mask the value of passwords in accessible value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 6e0dc0d19b369e28d75105b131b203ce7e6aac69..ca39c99c49aac957362be449e6fbe36647eb69a9 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -914,10 +914,12 @@ void Textfield::GetAccessibleState(ui::AXViewState* state) {
state->name = accessible_name_;
if (read_only())
state->AddStateFlag(ui::AX_STATE_READ_ONLY);
- if (text_input_type_ == ui::TEXT_INPUT_TYPE_PASSWORD)
+ if (text_input_type_ == ui::TEXT_INPUT_TYPE_PASSWORD) {
state->AddStateFlag(ui::AX_STATE_PROTECTED);
- state->value = text();
-
+ state->value = base::string16(text().size(), '*');
+ } else {
+ state->value = text();
+ }
const gfx::Range range = GetSelectedRange();
state->selection_start = range.start();
state->selection_end = range.end();

Powered by Google App Engine
This is Rietveld 408576698