Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 902783006: Mask the value of passwords in accessible value. (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
Peter Lundblad, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mask the value of passwords in accessible value. BUG=455428 Committed: https://crrev.com/3c793532564b05fc541e2d91a8df236614f6eda0 Cr-Commit-Position: refs/heads/master@{#316267}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add test. #

Patch Set 4 : Fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 3 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
David Tseng
5 years, 10 months ago (2015-02-10 00:52:18 UTC) #2
Peter Lundblad
Can we have some test added for this as well?
5 years, 10 months ago (2015-02-10 12:33:51 UTC) #3
David Tseng
On Tue, Feb 10, 2015 at 4:33 AM, <plundblad@chromium.org> wrote: > Can we have some ...
5 years, 10 months ago (2015-02-10 18:10:04 UTC) #4
Peter Lundblad
lgtm
5 years, 10 months ago (2015-02-11 14:41:31 UTC) #5
David Tseng
+ sky for ui/views/controls/textfield/textfield*
5 years, 10 months ago (2015-02-11 17:34:17 UTC) #9
sky
LGTM
5 years, 10 months ago (2015-02-11 18:46:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902783006/40001
5 years, 10 months ago (2015-02-11 19:18:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/9274)
5 years, 10 months ago (2015-02-11 20:09:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902783006/60001
5 years, 10 months ago (2015-02-13 19:03:43 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-13 20:02:40 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 20:03:30 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3c793532564b05fc541e2d91a8df236614f6eda0
Cr-Commit-Position: refs/heads/master@{#316267}

Powered by Google App Engine
This is Rietveld 408576698