Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: content/renderer/scheduler/renderer_scheduler_impl.cc

Issue 902783003: MouseMove when the mouse is down to signal compositor priority (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Brackets Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/scheduler/renderer_scheduler_impl.cc
diff --git a/content/renderer/scheduler/renderer_scheduler_impl.cc b/content/renderer/scheduler/renderer_scheduler_impl.cc
index 4ffe487b3764faa5abac556b86425a6f6469ee7b..abed6053221b51038e22fdc0c9f8a5f05c55fe9f 100644
--- a/content/renderer/scheduler/renderer_scheduler_impl.cc
+++ b/content/renderer/scheduler/renderer_scheduler_impl.cc
@@ -120,14 +120,23 @@ void RendererSchedulerImpl::DidCommitFrameToCompositor() {
}
void RendererSchedulerImpl::DidReceiveInputEventOnCompositorThread(
- blink::WebInputEvent::Type type) {
+ const blink::WebInputEvent& web_input_event) {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
"RendererSchedulerImpl::DidReceiveInputEventOnCompositorThread");
- // Ignore mouse events because on windows these can very frequent.
+ // We regard MouseMove events with the left mouse button down as a signsal
rmcilroy 2015/02/06 10:19:34 /s/signsal/signal
alex clarke (OOO till 29th) 2015/02/06 10:25:32 Done.
+ // that the user is doing something requiring a smooth frame rate.
+ if (web_input_event.type == blink::WebInputEvent::MouseMove &&
+ (web_input_event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
+ UpdateForInputEvent();
+ return;
+ }
+ // Ignore all other mouse events becuase they probably don't signal user
rmcilroy 2015/02/06 10:19:33 /s/becuase/because
alex clarke (OOO till 29th) 2015/02/06 10:25:32 Done.
+ // interaction needing a smooth framerate. NOTE isMouseEventType returns false
+ // for mouse wheel events, hence we regard them as user input.
// Ignore keyboard events because it doesn't really make sense to enter
// compositor priority for them.
- if (blink::WebInputEvent::isMouseEventType(type) ||
- blink::WebInputEvent::isKeyboardEventType(type)) {
+ if (blink::WebInputEvent::isMouseEventType(web_input_event.type) ||
+ blink::WebInputEvent::isKeyboardEventType(web_input_event.type)) {
return;
}
UpdateForInputEvent();
« no previous file with comments | « content/renderer/scheduler/renderer_scheduler_impl.h ('k') | content/renderer/scheduler/renderer_scheduler_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698