Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 902773003: Revert of Clean up V4L2 codec-related flags and defines (Closed)

Created:
5 years, 10 months ago by Pawel Osciak
Modified:
5 years, 10 months ago
Reviewers:
piman, wuchengli, henryhsu
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clean up V4L2 codec-related flags and defines (patchset #3 id:40001 of https://codereview.chromium.org/828063009/) Reason for revert: x86 Chrome compile failure due to https://code.google.com/p/chromium/issues/detail?id=455545. Original issue's description: > Clean up V4L2 codec-related flags and defines > > All arm platforms support V4L2 SVDA by default and use_v4l2_codec also governs V4L2 VDA/VEA now. > Generates libv4l2 stub in GN file. > > BUG=449883 > TEST=build chrome and vda unittest on peach_pit, veyron_pinky, squawks, > and panther_freon > > Committed: https://crrev.com/d5eeecc577f274bb8ed9d1954f263d83b5f00050 > Cr-Commit-Position: refs/heads/master@{#314536} TBR=piman@chromium.org,wuchengli@chromium.org,henryhsu@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449883 Committed: https://crrev.com/a3566c5c4784c9387ed188e1456dd557d9c7fca9 Cr-Commit-Position: refs/heads/master@{#314760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -90 lines) Patch
M content/common/BUILD.gn View 2 chunks +8 lines, -58 lines 0 comments Download
M content/common/common.gni View 1 chunk +4 lines, -5 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M content/content_common.gypi View 2 chunks +27 lines, -17 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Pawel Osciak
Created Revert of Clean up V4L2 codec-related flags and defines
5 years, 10 months ago (2015-02-05 05:06:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902773003/1
5 years, 10 months ago (2015-02-05 05:06:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 05:07:44 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 05:08:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3566c5c4784c9387ed188e1456dd557d9c7fca9
Cr-Commit-Position: refs/heads/master@{#314760}

Powered by Google App Engine
This is Rietveld 408576698