tools/telemetry/telemetry/page/record_wpr_unittest.py - Issue 902763002: Parallelize telemetry unit tests on Android bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/record_wpr_unittest.py

Issue 902763002: Parallelize telemetry unit tests on Android bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove fyi bot config (will create another CL for it) Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/record_wpr_unittest.py

diff --git a/tools/telemetry/telemetry/page/record_wpr_unittest.py b/tools/telemetry/telemetry/page/record_wpr_unittest.py

index 42467aefd40ad1ae5c65bdde0f74ffe804cc03ce..fcafadb2026a22b40329d7b9c35b35a06ee26e38 100644

--- a/tools/telemetry/telemetry/page/record_wpr_unittest.py

+++ b/tools/telemetry/telemetry/page/record_wpr_unittest.py

@@ -126,7 +126,8 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

@decorators.Disabled('chromeos') # crbug.com/404868.

def testWprRecorderWithPageSet(self):

- flags = ['--browser', self._browser.browser_type]

+ flags = ['--browser', self._browser.browser_type,

+ '--device', self._device]

mock_page_set = MockPageSet(url=self._url)

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir,

mock_page_set, flags)

@@ -136,7 +137,8 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

def testWprRecorderWithBenchmark(self):

flags = ['--mock-benchmark-url', self._url,

- '--browser', self._browser.browser_type]

+ '--browser', self._browser.browser_type,

+ '--device', self._device]

mock_benchmark = MockBenchmark()

wpr_recorder = record_wpr.WprRecorder(self._test_data_dir, mock_benchmark,

flags)

@@ -150,6 +152,7 @@ class RecordWprUnitTests(tab_test_case.TabTestCase):

'--page-set-base-dir', self._test_data_dir,

'--mock-benchmark-url', self._url,

'--browser', self._browser.browser_type,

+ '--device', self._device

]

mock_benchmark = MockBenchmark()

wpr_recorder = record_wpr.WprRecorder(