Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: tools/telemetry/telemetry/core/browser_options.py

Issue 902763002: Parallelize telemetry unit tests on Android bots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove fyi bot config (will create another CL for it) Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/browser_finder.py ('k') | tools/telemetry/telemetry/core/device_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/browser_options.py
diff --git a/tools/telemetry/telemetry/core/browser_options.py b/tools/telemetry/telemetry/core/browser_options.py
index 3a790386b9c4e28572056c23827a8b186a4541f5..69d0ae629ae217c5f0893feb644541ffd97dfea7 100644
--- a/tools/telemetry/telemetry/core/browser_options.py
+++ b/tools/telemetry/telemetry/core/browser_options.py
@@ -79,7 +79,8 @@ class BrowserFinderOptions(optparse.Values):
group.add_option('--device',
dest='device',
help='The device ID to use.'
- 'If not specified, only 0 or 1 connected devices are supported.')
+ 'If not specified, only 0 or 1 connected devices are supported. If'
+ 'specified as "android", all available Android devices are used.')
group.add_option('--target-arch',
dest='target_arch',
help='The target architecture of the browser. Options available are: '
@@ -161,20 +162,16 @@ class BrowserFinderOptions(optparse.Values):
logging.getLogger().setLevel(logging.WARNING)
if self.device == 'list':
- devices = device_finder.GetAllAvailableDeviceNames(self)
+ devices = device_finder.GetDevicesMatchingOptions(self)
print 'Available devices:'
for device in devices:
- print ' ', device
+ print ' ', device.name
sys.exit(0)
if self.browser_executable and not self.browser_type:
self.browser_type = 'exact'
if self.browser_type == 'list':
- devices = []
- if self.device and self.device != 'list':
- devices = device_finder.GetSpecifiedDevices(self)
- else:
- devices = device_finder.GetAllAvailableDevices(self)
+ devices = device_finder.GetDevicesMatchingOptions(self)
if not devices:
sys.exit(0)
browser_types = {}
« no previous file with comments | « tools/telemetry/telemetry/core/browser_finder.py ('k') | tools/telemetry/telemetry/core/device_finder.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698