Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: ui/views/widget/widget.h

Issue 9027020: Bypass ToplevelWindowEventFilter for panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge/sync Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/widget/native_widget_win.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.h
diff --git a/ui/views/widget/widget.h b/ui/views/widget/widget.h
index eed8f18cce1ed2f09101735c7fa0dccba460b625..2af755c916cfe86dd3f064d749052aced2b51363 100644
--- a/ui/views/widget/widget.h
+++ b/ui/views/widget/widget.h
@@ -111,6 +111,8 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
enum Type {
TYPE_WINDOW, // A decorated Window, like a frame window.
// Widgets of TYPE_WINDOW will have a NonClientView.
+ TYPE_PANEL, // Always on top window managed by PanelManager.
+ // Widgets of TYPE_PANEL will have a NonClientView.
TYPE_WINDOW_FRAMELESS,
// An undecorated Window.
TYPE_CONTROL, // A control, like a button.
@@ -211,8 +213,8 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
static Widget* GetWidgetForNativeWindow(gfx::NativeWindow native_window);
// Retrieves the top level widget in a native view hierarchy
- // starting at |native_view|. Top level widget is a widget with
- // TYPE_WINDOW, TYPE_WINDOW_FRAMELESS, POPUP or MENU and has its own
+ // starting at |native_view|. Top level widget is a widget with TYPE_WINDOW,
+ // TYPE_PANEL, TYPE_WINDOW_FRAMELESS, POPUP or MENU and has its own
// focus manager. This may be itself if the |native_view| is top level,
// or NULL if there is no toplevel in a native view hierarchy.
static Widget* GetTopLevelWidgetForNativeView(gfx::NativeView native_view);
@@ -251,7 +253,7 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
// Returns the gfx::NativeWindow associated with this Widget. This may return
// NULL on some platforms if the widget was created with a type other than
- // TYPE_WINDOW.
+ // TYPE_WINDOW or TYPE_PANEL.
gfx::NativeWindow GetNativeWindow() const;
// Add/remove observer.
@@ -556,9 +558,9 @@ class VIEWS_EXPORT Widget : public internal::NativeWidgetDelegate,
virtual View* GetChildViewParent();
// True if the widget is considered top level widget. Top level widget
- // is a widget of TYPE_WINDOW, TYPE_WINDOW_FRAMELESS, BUBBLE, POPUP or MENU,
- // and has a focus manager and input method object associated with it.
- // TYPE_CONTROL and TYPE_TOOLTIP is not considered top level.
+ // is a widget of TYPE_WINDOW, TYPE_PANEL, TYPE_WINDOW_FRAMELESS, BUBBLE,
+ // POPUP or MENU, and has a focus manager and input method object associated
+ // with it. TYPE_CONTROL and TYPE_TOOLTIP is not considered top level.
bool is_top_level() const { return is_top_level_; }
// Returns the bounds of work area in the screen that Widget belongs to.
« no previous file with comments | « ui/views/widget/native_widget_win.cc ('k') | ui/views/widget/widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698