Bypass ToplevelWindowEventFilter for panels.

ui/aura_shell/stacking_controller.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura_shell/stacking_controller.h"
 
 #include "ui/aura/client/aura_constants.h"
 #include "ui/aura/root_window.h"
 #include "ui/aura/window.h"
 #include "ui/aura_shell/always_on_top_controller.h"
 #include "ui/aura_shell/shell.h"
 #include "ui/aura_shell/shell_window_ids.h"
 
 namespace aura_shell {
 namespace internal {
 namespace {
 
 aura::Window* GetContainer(int id) {
   return Shell::GetInstance()->GetContainer(id);
 }
 
 bool IsWindowModal(aura::Window* window) {
   return window->transient_parent() && window->GetIntProperty(aura::kModalKey);
 }
 
+bool IsWindowPanel(aura::Window* window) {
+  return window->GetIntProperty(aura::kPanelKey);
+}
+
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // StackingController, public:
 
 StackingController::StackingController() {
   aura::client::SetStackingClient(this);
   always_on_top_controller_.reset(new internal::AlwaysOnTopController);
   always_on_top_controller_->SetContainers(
       GetContainer(internal::kShellWindowId_DefaultContainer),
       GetContainer(internal::kShellWindowId_AlwaysOnTopContainer));
 }
 
 StackingController::~StackingController() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // StackingController, aura::StackingClient implementation:
 
 aura::Window* StackingController::GetDefaultParent(aura::Window* window) {
   switch (window->type()) {
     case aura::WINDOW_TYPE_NORMAL:
     case aura::WINDOW_TYPE_POPUP:
       if (IsWindowModal(window))
         return GetModalContainer(window);
-      return always_on_top_controller_->GetContainer(window);
+      else if (IsWindowPanel(window))

[Ben Goodger (Google), 2011/12/22 23:22:45]

nit: no else after return, here and below:

[prasadt, 2011/12/23 01:51:40]

Done.

+        return GetContainer(internal::kShellWindowId_PanelContainer);
+      else
+        return always_on_top_controller_->GetContainer(window);
     case aura::WINDOW_TYPE_MENU:
     case aura::WINDOW_TYPE_TOOLTIP:
       return GetContainer(internal::kShellWindowId_MenusAndTooltipsContainer);
     default:
       NOTREACHED() << "Window " << window->id()
                    << " has unhandled type " << window->type();
       break;
   }
   return NULL;
 }
@@ skipping 22 matching lines @@
   if (window_container_id < lock_container_id)
     container = GetContainer(internal::kShellWindowId_ModalContainer);
   else
     container = GetContainer(internal::kShellWindowId_LockModalContainer);
 
   return container;
 }
 
 }  // namespace internal
 }  // namespace aura_shell