Bypass ToplevelWindowEventFilter for panels.

Bypass ToplevelWindowEventFilter for panels.

With this change minimize and drag work on panels in Aura.

BUG=108497
TEST=Run chrome in aura. Create a panel. Click on titlebar. Drag.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=115850

[Ben Goodger (Google), 2011-12-22 23:22:45]

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/shell_window_ids.h
File ui/aura_shell/shell_window_ids.h (right):

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/shell_window_ids....
ui/aura_shell/shell_window_ids.h:28: const int kShellWindowId_PanelContainer =
4;
You add this container before the launcher container in the code, so it should
be before it in this list.

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/stacking_controll...
File ui/aura_shell/stacking_controller.cc (right):

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/stacking_controll...
ui/aura_shell/stacking_controller.cc:55: else if (IsWindowPanel(window))
nit: no else after return, here and below:

http://codereview.chromium.org/9027020/diff/1/ui/views/widget/native_widget_a...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/9027020/diff/1/ui/views/widget/native_widget_a...
ui/views/widget/native_widget_aura.cc:189:
window_->SetIntProperty(aura::kPanelKey, params.is_panel);
So, I looked at code in the aura shell, and I believe you may be able to safely
add a new TYPE_PANEL to InitParams::Type, and a corresponding type to WindowType
in ui/aura/client/window_types.h. I don't see any code that is triggered on
TYPE_WINDOW that is relevant to panels.

[prasadt, 2011-12-23 01:51:40]

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/shell_window_ids.h
File ui/aura_shell/shell_window_ids.h (right):

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/shell_window_ids....
ui/aura_shell/shell_window_ids.h:28: const int kShellWindowId_PanelContainer =
4;
On 2011/12/22 23:22:45, Ben Goodger (Google) wrote:
> You add this container before the launcher container in the code, so it should
> be before it in this list.

Done.

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/stacking_controll...
File ui/aura_shell/stacking_controller.cc (right):

http://codereview.chromium.org/9027020/diff/1/ui/aura_shell/stacking_controll...
ui/aura_shell/stacking_controller.cc:55: else if (IsWindowPanel(window))
On 2011/12/22 23:22:45, Ben Goodger (Google) wrote:
> nit: no else after return, here and below:

Done.

http://codereview.chromium.org/9027020/diff/1/ui/views/widget/native_widget_a...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/9027020/diff/1/ui/views/widget/native_widget_a...
ui/views/widget/native_widget_aura.cc:189:
window_->SetIntProperty(aura::kPanelKey, params.is_panel);
On 2011/12/22 23:22:45, Ben Goodger (Google) wrote:
> So, I looked at code in the aura shell, and I believe you may be able to
safely
> add a new TYPE_PANEL to InitParams::Type, and a corresponding type to
WindowType
> in ui/aura/client/window_types.h. I don't see any code that is triggered on
> TYPE_WINDOW that is relevant to panels.

Done.

[Ben Goodger (Google), 2011-12-23 01:56:40]

lgtm

[stevenjb, 2011-12-27 19:14:05]

lgtm

[commit-bot: I haz the power, 2011-12-27 20:26:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/prasadt@chromium.org/9027020/14001

[commit-bot: I haz the power, 2011-12-27 21:38:09]

Try job failure for 9027020-14001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...