Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 902683002: Remove usage of RenderViewHost which aren't needed anymore. (Closed)

Created:
5 years, 10 months ago by nasko
Modified:
5 years, 10 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-dev_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of RenderViewHost which aren't needed anymore. BUG=304341 Committed: https://crrev.com/55b3eab0bc43d35f7883dde31d06d122d2c20f47 Cr-Commit-Position: refs/heads/master@{#314648}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove static casts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M content/browser/frame_host/frame_tree.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nasko
Hey Charlie, This is some simple cleanup, which you suggested should be in a separate ...
5 years, 10 months ago (2015-02-04 19:50:17 UTC) #2
Charlie Reis
Let's use 304341 as the bug number. LGTM with nits! https://codereview.chromium.org/902683002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/902683002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode268 ...
5 years, 10 months ago (2015-02-04 20:37:14 UTC) #3
nasko
Fixed the nits. https://codereview.chromium.org/902683002/diff/1/content/browser/frame_host/navigator_impl.cc File content/browser/frame_host/navigator_impl.cc (right): https://codereview.chromium.org/902683002/diff/1/content/browser/frame_host/navigator_impl.cc#newcode268 content/browser/frame_host/navigator_impl.cc:268: static_cast<SiteInstanceImpl*>(render_frame_host->GetSiteInstance())); On 2015/02/04 20:37:14, Charlie Reis ...
5 years, 10 months ago (2015-02-04 20:42:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902683002/20001
5 years, 10 months ago (2015-02-04 20:43:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-04 21:54:45 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 21:55:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55b3eab0bc43d35f7883dde31d06d122d2c20f47
Cr-Commit-Position: refs/heads/master@{#314648}

Powered by Google App Engine
This is Rietveld 408576698