Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 902663002: Make default font size in Files.app slightly larger. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make default font size in Files.app slightly larger. This CL changes default font size to comply with the design spec. BUG=402344 TEST=none Committed: https://crrev.com/940e7a019588f798a28de2bf4084e0cb3e584980 Cr-Commit-Position: refs/heads/master@{#314992}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +1 line, -0 lines 3 comments Download

Messages

Total messages: 10 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 10 months ago (2015-02-05 18:16:04 UTC) #2
yawano
https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode51 ui/file_manager/file_manager/foreground/css/file_manager.css:51: font-size: 81%; Is this a change to make font-size ...
5 years, 10 months ago (2015-02-06 01:33:23 UTC) #3
fukino
https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode51 ui/file_manager/file_manager/foreground/css/file_manager.css:51: font-size: 81%; On 2015/02/06 01:33:23, yawano wrote: > Is ...
5 years, 10 months ago (2015-02-06 06:39:21 UTC) #4
yawano
lgtm. https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css File ui/file_manager/file_manager/foreground/css/file_manager.css (right): https://codereview.chromium.org/902663002/diff/1/ui/file_manager/file_manager/foreground/css/file_manager.css#newcode51 ui/file_manager/file_manager/foreground/css/file_manager.css:51: font-size: 81%; On 2015/02/06 06:39:21, fukino wrote: > ...
5 years, 10 months ago (2015-02-06 06:46:41 UTC) #5
fukino
Thanks!
5 years, 10 months ago (2015-02-06 06:53:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902663002/1
5 years, 10 months ago (2015-02-06 06:53:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 07:19:14 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 07:20:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/940e7a019588f798a28de2bf4084e0cb3e584980
Cr-Commit-Position: refs/heads/master@{#314992}

Powered by Google App Engine
This is Rietveld 408576698