Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Issue 902643003: Revert of Update geolocation permission tests for the permission bubble (Closed)

Created:
5 years, 10 months ago by ccameron
Modified:
5 years, 10 months ago
CC:
chromium-reviews, markusheintz_, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update geolocation permission tests for the permission bubble (patchset #18 id:340001 of https://codereview.chromium.org/787033004/) Reason for revert: Getting intermittent failures in GeolocationBrowserTest after this patch Failing build: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/35949/steps/browser_tests Output: GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1 (run #1): [ RUN ] GeolocationBrowserTestWithParams/GeolocationBrowserTest.NoLeakFromOffTheRecord/1 [3952:1032:0204/052930:WARNING:data_reduction_proxy_settings.cc(345)] SPDY proxy OFF at startup [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000 [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=04CF00A6 [3952:1032:0204/052930:WARNING:geolocation_browsertest.cc(383)] before navigate [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(156)] LegacyRenderWidgetHostHWND::OnGetObject message=61 w_param=0 l_param=-12 obj_id=4294967284 host_=00000000 [3952:1032:0204/052930:INFO:legacy_render_widget_host_win.cc(129)] LegacyRenderWidgetHostHWND::Init hwnd=08B500B0 [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(398)] after navigate [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(234)] will add geolocation watch for bubble [3952:1032:0204/052931:WARNING:geolocation_browsertest.cc(201)] javascript_response 1 [3952:3868:0204/052931:WARNING:embedded_test_server.cc(248)] Request not handled. Returning 404: /favicon.ico Output not very helpful here, but perhaps it makes sense to a non-sheriff. Original issue's description: > Update geolocation permission tests for the permission bubble > > This makes the geolocation permission tests run for both infobars and > permission bubbles. The tests now run as parameterized tests. > > Supercedes parts of: > https://codereview.chromium.org/411503005/ > https://codereview.chromium.org/341833004/ > > BUG=438758 > > Committed: https://crrev.com/f57c61952870c6027dbf220eff8b2d703bfed3c8 > Cr-Commit-Position: refs/heads/master@{#314541} TBR=mvanouwerkerk@chromium.org,timvolodine@google.com,markusheintz@chromium.org,felt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=438758 Committed: https://crrev.com/d063c31420f30a7ac24fc3b5832bbd3e86f4e94e Cr-Commit-Position: refs/heads/master@{#314602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+432 lines, -829 lines) Patch
M chrome/browser/geolocation/geolocation_browsertest.cc View 32 chunks +134 lines, -220 lines 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context_unittest.cc View 19 chunks +298 lines, -488 lines 0 comments Download
D chrome/browser/ui/website_settings/mock_permission_bubble_view.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/website_settings/mock_permission_bubble_view.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/ui/website_settings/permission_bubble_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ccameron
Created Revert of Update geolocation permission tests for the permission bubble
5 years, 10 months ago (2015-02-04 19:08:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/902643003/1
5 years, 10 months ago (2015-02-04 19:09:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 19:11:20 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d063c31420f30a7ac24fc3b5832bbd3e86f4e94e Cr-Commit-Position: refs/heads/master@{#314602}
5 years, 10 months ago (2015-02-04 19:12:32 UTC) #4
felt
5 years, 10 months ago (2015-02-05 10:51:32 UTC) #5
Message was sent while issue was closed.
thanks ccameron

Powered by Google App Engine
This is Rietveld 408576698