Fix a bunch of issues blocking 64-bit orderfile generation.

tools/cygprofile/symbol_extractor.py

Index: tools/cygprofile/symbol_extractor.py
diff --git a/tools/cygprofile/symbol_extractor.py b/tools/cygprofile/symbol_extractor.py
index 5fd67a1d65bd25aae696fb6674e717f5e096e4d3..f0046d2eedb412e1fa5d02e6b5672abaa0105e2b 100755
--- a/tools/cygprofile/symbol_extractor.py
+++ b/tools/cygprofile/symbol_extractor.py
@@ -17,15 +17,18 @@ sys.path.insert(
                     'scripts'))
 import symbol
 
-
-# TODO(lizeb): Change symbol.ARCH to the proper value when "arm" is no longer
-# the only possible value.
 _OBJDUMP_BINARY = symbol.ToolPath('objdump')
 
 
 SymbolInfo = collections.namedtuple('SymbolInfo', ('name', 'offset', 'size',
                                                    'section'))
 
+def SetArchitecture(arch):
+  """Set the architecture for binaries to be symbolized."""
+  symbol.ARCH = arch
+  global _OBJDUMP_BINARY

[pasko, 2015/02/04 19:08:26]

let's not increase global state. How about _GetObjdumpBinary()?

[azarchs, 2015/02/05 09:40:02]

This isn't increasing global state - just changing the content of a variable
that is already global.  Do we want to do make that variable not global?  It
sounds like a good idea, but would be a more extensive change as we'd need to
turn this whole file into a class instead of a bunch of global methods.

[pasko, 2015/02/05 10:24:50]

Let's eliminate the _OBJDUMP_BINARY (referenced only once in this file), and
always call symbol.ToolPath('objdump').

The SetArchitecture(arch) would stay and be a one liner to modify the
symbol.ARCH in an obvious way.

WDYT?

[azarchs, 2015/02/05 10:31:01]

Done.

+  _OBJDUMP_BINARY = symbol.ToolPath('objdump')
+
 
 def _FromObjdumpLine(line):
   """Create a SymbolInfo by parsing a properly formatted objdump output line.